Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HB-6543] Add API to Allow Game Publishers to Specify the ChartboostMediationSettings Object #197

Conversation

SCastanedaMunoz
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz commented Oct 25, 2023

Title

HB-6543 Add API to Allow Game Publishers to Specify the ChartboostMediationSettings Object

Description

The Unity SDK loads assets (configuration data) directly from the Resources directory. That’s not DLC-aware, and doesn’t play nicely if the game has a custom asset manager/loader. It would be great to provide a way for the game to specify the settings object.

We provide a setter for the ChartboostMediationSettings.Instance, and we also allow the modified instance to be set on the Configuration Window, as seen in the screenshot below.

Screenshot 2023-10-25 at 2 39 23 PM

We have removed the existing InspectorGUI for the ChartboostMediationSettings since it is no longer needed, and it did not played well with the existing settings.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SCastanedaMunoz SCastanedaMunoz added enhancement New feature or request api refactoring API refactoring features or changes labels Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz requested a review from a team October 25, 2023 19:41
@SCastanedaMunoz SCastanedaMunoz self-assigned this Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from bwised, kushG and cb-jpadilla and removed request for a team October 25, 2023 19:41
Copy link
Contributor

@cb-jpadilla cb-jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions
Copy link

Test Results

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit cdb7c9e.

@SCastanedaMunoz SCastanedaMunoz merged commit 1fd6686 into develop Oct 25, 2023
3 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6543-zynga-audit-unity-add-api-to-allow-game-publishers-to-specify-the-settings-object branch October 25, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api refactoring API refactoring features or changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants