Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HB-6639] Adds ContainerSize to BannerView API #194

Conversation

kushG
Copy link
Contributor

@kushG kushG commented Oct 20, 2023

Title

HB-6639 Adds ContainerSize to bannerView API

Description

Unity developers do not have any means to get the size of the banner container since the container (BannerView )exists on native layer. With this PR they will be able to call ContainerSize to get such size.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kushG kushG marked this pull request as ready for review October 20, 2023 00:40
@kushG kushG requested review from a team, bwised, cb-jpadilla and SCastanedaMunoz and removed request for a team October 20, 2023 00:40
@kushG kushG changed the title [HB-6639] Adds ContainerSize to bannerView API [HB-6639] Adds ContainerSize to BannerView API Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 51d892c. ± Comparison against base commit e203296.

♻️ This comment has been updated with latest results.

@kushG kushG self-assigned this Oct 20, 2023
@kushG kushG added the api refactoring API refactoring features or changes label Oct 20, 2023
@kushG kushG merged commit 4aff243 into develop Oct 20, 2023
3 checks passed
@kushG kushG deleted the HB-6639-helium-unity-canary-fix-get-container-size-of-banner-controller-ad branch October 20, 2023 22:36
@SCastanedaMunoz SCastanedaMunoz added the bugfix Something has been fixed label Oct 25, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api refactoring API refactoring features or changes bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants