Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-5903] Add LineItemName to BidInfo #145

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[HB-5903] Add LineItemName to BidInfo #145

merged 1 commit into from
Jun 12, 2023

Conversation

SCastanedaMunoz
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz commented Jun 12, 2023 •
edited
Loading

Description

Previous PR added LineItemId however we still need to add the LineItemName. This PR fixes that

@SCastanedaMunoz SCastanedaMunoz added the bugfix Something has been fixed label Jun 12, 2023
@SCastanedaMunoz SCastanedaMunoz requested a review from a team June 12, 2023 18:14
@SCastanedaMunoz SCastanedaMunoz self-assigned this Jun 12, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from bwised, kushG and cb-jpadilla and removed request for a team June 12, 2023 18:14
@SCastanedaMunoz SCastanedaMunoz changed the title [HB-5903] Adding LineItemName to BidInfo [HB-5903] Add LineItemName to BidInfo Jun 12, 2023
@SCastanedaMunoz SCastanedaMunoz added the enhancement New feature or request label Jun 12, 2023
@github-actions
Copy link

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 19f619c. ± Comparison against base commit 7c1d17e.

kushG
kushG approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@kushG kushG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SCastanedaMunoz SCastanedaMunoz merged commit 0d32fc5 into release/4.3.0 Jun 12, 2023
@SCastanedaMunoz SCastanedaMunoz deleted the HB-5903-unity-zade-add-line-item-name-to-the-bid-info-object branch June 12, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushG kushG kushG approved these changes

@bwised bwised Awaiting requested review from bwised bwised was automatically assigned from ChartBoost/helium-unity

@cb-jpadilla cb-jpadilla Awaiting requested review from cb-jpadilla cb-jpadilla was automatically assigned from ChartBoost/helium-unity

Assignees

@SCastanedaMunoz SCastanedaMunoz

Labels
bugfix Something has been fixed enhancement New feature or request
Projects
None yet
Milestone
Chartboost Mediation Unity SDK 4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SCastanedaMunoz @kushG