Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-5829] Update Unity Editor Adapter Window to Use New v2 Partners JSON #130

Merged
merged 2 commits into from
May 10, 2023
Merged

[HB-5829] Update Unity Editor Adapter Window to Use New v2 Partners JSON #130

merged 2 commits into from
May 10, 2023

Conversation

SCastanedaMunoz
Copy link
Collaborator

Description

Utilizing new v2 partners.json file for a more comprehensive coverage of network changes.

@SCastanedaMunoz SCastanedaMunoz added enhancement New feature or request bugfix Something has been fixed labels May 9, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from pleasesavemycat and a team May 9, 2023 22:16
@SCastanedaMunoz SCastanedaMunoz self-assigned this May 9, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from bwised, kushG and cb-jpadilla and removed request for a team May 9, 2023 22:16
@SCastanedaMunoz SCastanedaMunoz changed the base branch from develop to release/4.2.2 May 9, 2023 22:16
pleasesavemycat
pleasesavemycat approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@pleasesavemycat pleasesavemycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cb-jpadilla
cb-jpadilla approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@cb-jpadilla cb-jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small nit: a few files need an EOL.

@github-actions
Copy link

github-actions bot commented May 9, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 33bd281. ± Comparison against base commit a4817e4.

@SCastanedaMunoz SCastanedaMunoz merged commit 42f6bb9 into release/4.2.2 May 10, 2023
@SCastanedaMunoz SCastanedaMunoz deleted the HB-5829-update-unity-editor-adapter-window-to-use-new-v2-partners-json branch May 10, 2023 17:27
@SCastanedaMunoz SCastanedaMunoz mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-jpadilla cb-jpadilla cb-jpadilla approved these changes

@pleasesavemycat pleasesavemycat pleasesavemycat approved these changes

@bwised bwised Awaiting requested review from bwised bwised was automatically assigned from ChartBoost/helium-unity

@kushG kushG Awaiting requested review from kushG kushG was automatically assigned from ChartBoost/helium-unity

Assignees

@SCastanedaMunoz SCastanedaMunoz

Labels
bugfix Something has been fixed enhancement New feature or request
Projects
None yet
Milestone
Chartboost Mediation Unity SDK 4.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SCastanedaMunoz @pleasesavemycat @cb-jpadilla