Feat: Add CC2 support #11
Conversation
| } | ||
|
|
||
|
|
||
| def allowed_product_ids(*product_ids: int): | ||
| def allowed_product_ids(*product_ids: (int, str)): |
There was a problem hiding this comment.
suggestion: Shall we consider product_ids: {int: str}? A dict seems easier to type and use than key-value pairs.
There was a problem hiding this comment.
Dict dereferencing for decorators was messy, feel free to change it as long as you can make it work
There was a problem hiding this comment.
Were you referring to dereferencing a **kwargs-like dict? I do notice that it currently also uses a *args-like sequence. I would personally prefer to use only one parameter which is a container. Such as:
| def allowed_product_ids(*product_ids: (int, str)): | |
| def allowed_product_ids(product_ids: {int, str}): |
and then it would be used like this:
@allowed_product_ids({
0x8189: "S2",
0x818A: "S2 - UF2 Bootloader",
})
class CharaChorderEngine(CharaChorder):... as long as you can make it work
Admittedly, I haven't tested it in this code base (don't know how), but the usage above should work.
There was a problem hiding this comment.
We shouldn't be messing with any of this IMO. Will get to it once I have the time for a review
No description provided.