-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 添加注册登录&同步聊天数据 #417
feat: 添加注册登录&同步聊天数据 #417
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | SMTP credentials | 4fe12d9 | docker-compose/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
这应该另起一个分支! |
就算不启用 默认和现在没区别 唯一就是 docker 打包大了些 但是数据库还是要的 |
赞! 数据库如果用sqlite 会减少一点部署的麻烦. sqlite 个人使用时足够了 |
915f51c
to
4fe12d9
Compare
这种强制MongoDB的侵入式改动应该不会直接合并到主分支,应该新起一个分支,db应该是可选项,比如mongo、maridb、sqlite,前两个可以传入变量以配置连接参数,这样是比较容易令人接受的 |
既然有了数据库,还希望能支持保存和恢复回话记录,类似于现在的导入导出功能,只不过现在是保存在访问设备在地。数据库推荐mongo,对json储存比较友好。 |
db 应该没有可选一说 加了再可选 会一堆代码判断,但是可以支持sqlite之类的 |
每次刷新页面会重新从数据库拉去会话的 所以有 db 导入导出作用就不大(除非你想分享自己的聊天完整给别人 |
docker 部署的话 看看 你的 docker-compose 里的 SITE_DOMAIN 变量设置下 |
|
当一次聊天觉得当前聊天不错,可以点击保存,于是就把json保存到数据库里,但是这个保存的聊天不需要多设备同步显示到左边的chat列表里。只需要在点击”导入”的时候,可以选择之前保存的聊天记录恢复到聊天框。当接着又聊了新内容,再保存的时候,就更新json。 |
great addition, would be even better to display email / name in the user info screen and as others suggested - have a "log out" function |
现在这个版本还适用吗 |
不行。尝试添加后,出现了bug |
@ludashi2020 @luckywangxi @rzarvirov #589 |
哇,明早起来试试 |
感谢分享,明早试试 |
AUTH_SECRET_KEY设置不为空,没有出现登录界面 |
新的bug,关于注册账号时,如果邮件发送后,用户没接收到,则无法重新发送邮件 |
开启登录