Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: fix dependencies #289

Merged
merged 1 commit into from
Sep 19, 2023
Merged

build!: fix dependencies #289

merged 1 commit into from
Sep 19, 2023

Conversation

joshuasing
Copy link
Member

@joshuasing joshuasing commented Sep 19, 2023

Summary
Fix Gradle dependency problem (@joshuasing PEBKAC) introduced in 21ec9eb
compileOnlyApi results in the Maven scope compile which causes the dependency to be included by the Maven shade plugin.

Use compileOnly for platform dependencies (e.g. Bukkit, BungeeCord).
Use api for dependencies that should be transitvely exported to consumers (e.g. chameleon-api, adventure).

More information: https://docs.gradle.org/current/userguide/java_library_plugin.html

Changes

  • Use api for Chameleon dependencies.
  • Use compileOnly for platform dependencies.

Checklist

This pull request contains breaking build changes.

`compileOnlyApi` results in the Maven scope `compile` which causes the
dependency to be included by the Maven shade plugin.

Previously, all external dependencies that should not be included in the
compiled plugin were using `compileOnlyApi`.
@joshuasing joshuasing added this to the v0.19.0 milestone Sep 19, 2023
@joshuasing joshuasing added type: bug: fix A bug fix area: build This involves updating, adding or removing a build file labels Sep 19, 2023
@joshuasing joshuasing self-assigned this Sep 19, 2023
@joshuasing joshuasing merged commit 6f00201 into main Sep 19, 2023
3 checks passed
@joshuasing joshuasing deleted the build/fix-deps branch September 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build This involves updating, adding or removing a build file type: bug: fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants