Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add platform-api module (fix #287) #288

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

joshuasing
Copy link
Member

Summary
Move Platform API into a separate module (platform-api)
Resolves #287

Changes

  • Add platform-api module
  • Move PlatformChameleon into platform-api module
  • Add dependance on platform-api to all platforms
  • Remove PlatformChameleon from api unit tests

Checklist

@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature area: platform This involves updating, adding or removing a platform area: build This involves updating, adding or removing a build file type: refactor This refactors existing code area: api labels Sep 18, 2023
@joshuasing joshuasing self-assigned this Sep 18, 2023
@joshuasing joshuasing removed area: build This involves updating, adding or removing a build file area: api type: enhancement This is a feature request or a pull request that adds a feature labels Sep 18, 2023
@joshuasing joshuasing added this to the v0.19.0 milestone Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #288 (fcf09d7) into main (57e9b80) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #288      +/-   ##
============================================
- Coverage     70.92%   70.85%   -0.08%     
+ Complexity      407      405       -2     
============================================
  Files            73       72       -1     
  Lines          1517     1513       -4     
  Branches         87       87              
============================================
- Hits           1076     1072       -4     
  Misses          407      407              
  Partials         34       34              

see 1 file with indirect coverage changes

@joshuasing joshuasing merged commit b217888 into main Sep 19, 2023
5 checks passed
@joshuasing joshuasing deleted the feat/platform-api branch September 19, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: platform This involves updating, adding or removing a platform type: refactor This refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Platform API into a separate module (platform-api)
2 participants