fix(api): add UserChatEvent #isCancellable and #isModifiable
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes in Minecraft 1.19.1+, some platforms no longer support cancelling or modifying the chat event. Add `UserChatEvent#isCancellable()` and `UserChatEvent#isModifiable()` to allow developers to determine whether these operations are supported on the current platform. If `UserChatEvent#isCancellable()` returns false, but the event is cancelled, the event will not be cancelled on the platform. If `UserChatEvent#isModifiable()` returns false, but the chat message is modified, the event's chat message will not be changed on the platform.
joshuasing
added
type: enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
============================================
- Coverage 71.40% 70.92% -0.48%
Complexity 407 407
============================================
Files 72 73 +1
Lines 1507 1517 +10
Branches 87 87
============================================
Hits 1076 1076
- Misses 397 407 +10
Partials 34 34
|
1 task
LooFifteen
approved these changes
Sep 6, 2023
...rm-velocity/src/main/java/dev/hypera/chameleon/platform/velocity/event/VelocityListener.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to changes in Minecraft 1.19.1+, some platforms no longer support cancelling or modifying the chat event.
This pull request adds
UserChatEvent#isCancellable()andUserChatEvent#isModifiable()to allow developers to determine whether these operations are supported on the current platform.If
UserChatEvent#isCancellable()returns false, but the event is cancelled, the event will not be cancelled on the platform.If
UserChatEvent#isModifiable()returns false, but the chat message is modified, the event's chat message will not be changed on the platform.Changes
UserChatEvent#isCancellable()UserChatEvent#isModifiable()Checklist