Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Folia Support #217

Merged
merged 4 commits into from
Apr 2, 2023
Merged

feat: add Folia Support #217

merged 4 commits into from
Apr 2, 2023

Conversation

LooFifteen
Copy link
Member

Summary
Adds Folia support to Chameleon

Changes

  • Use Paper's plugin loader.
  • Use Paper's plugin management API.
  • Use Folia's scheduling API.

Checklist

joshuasing
joshuasing requested changes Apr 2, 2023
View reviewed changes
Copy link
Member

@joshuasing joshuasing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are just a few things that I noticed :)

build-logic/src/main/kotlin/chameleon.base.gradle.kts Outdated Show resolved Hide resolved
example/src/main/java/dev/hypera/chameleon/example/ChameleonExample.java Outdated Show resolved Hide resolved
platform-bukkit/src/main/java/dev/hypera/chameleon/platform/bukkit/BukkitChameleon.java Show resolved Hide resolved
platform-folia/src/main/java/dev/hypera/chameleon/platform/folia/FoliaChameleon.java Show resolved Hide resolved
platform-folia/src/main/java/dev/hypera/chameleon/platform/folia/FoliaChameleon.java Show resolved Hide resolved
@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature area: platform This involves updating, adding or removing a platform status: breaking This involves breaking an existing API platform: server This affects server platforms area: annotations This involves updating, adding or removing code relating to annotation processing labels Apr 2, 2023
@joshuasing joshuasing added this to the v1.0.0 milestone Apr 2, 2023
@LooFifteen LooFifteen merged commit f3a6a0c into main Apr 2, 2023
@LooFifteen LooFifteen deleted the feat/platform-folia branch April 2, 2023 10:21
@joshuasing joshuasing mentioned this pull request Apr 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuasing joshuasing joshuasing approved these changes

Assignees

@LooFifteen LooFifteen

Labels
area: annotations This involves updating, adding or removing code relating to annotation processing area: platform This involves updating, adding or removing a platform platform: server This affects server platforms status: breaking This involves breaking an existing API type: enhancement This is a feature request or a pull request that adds a feature
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LooFifteen @joshuasing