Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions)!: improve and simplify extensions system #205

Merged
merged 10 commits into from
Apr 4, 2023

Conversation

joshuasing
Copy link
Member

@joshuasing joshuasing commented Mar 7, 2023

Summary
Replaces the current extension system with an easier to use, cleaner, and simpler system.
Resolves #203

Changes

  • Replace the current extension system with improved system.
  • Add ChameleonLoadEvent, ChameleonEnableEvent and ChameleonDisableEvent.
  • Add 100% test coverage for new extension system.
  • Add 100% test coverage for Preconditions.
  • Add 100% test coverage for ChameleonUtil.
  • Bump version to 0.15.0-SNAPSHOT.

Checklist

This pull request contains breaking changes.

@joshuasing joshuasing self-assigned this Mar 7, 2023
@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature type: test This involves updating, adding or removing a test type: feature This adds a new feature type: refactor This refactors existing code area: extensions labels Mar 7, 2023
@joshuasing joshuasing added this to the v1.0.0 milestone Mar 7, 2023
@joshuasing joshuasing marked this pull request as ready for review March 7, 2023 15:40
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #205 (c433719) into main (4960589) will increase coverage by 7.43%.
The diff coverage is 92.10%.

❗ Current head c433719 differs from pull request most recent head 39ad890. Consider uploading reports for the commit 39ad890 to get more accurate results

@@             Coverage Diff              @@
##               main     #205      +/-   ##
============================================
+ Coverage     61.86%   69.29%   +7.43%     
- Complexity      293      387      +94     
============================================
  Files            61       73      +12     
  Lines          1416     1557     +141     
  Branches         74       87      +13     
============================================
+ Hits            876     1079     +203     
+ Misses          504      443      -61     
+ Partials         36       35       -1     
Impacted Files Coverage Δ
...ra/chameleon/adventure/mapper/AdventureMapper.java 100.00% <ø> (ø)
.../chameleon/event/common/ChameleonDisableEvent.java 0.00% <0.00%> (ø)
...a/chameleon/event/common/ChameleonEnableEvent.java 0.00% <0.00%> (ø)
...chameleon/extension/ChameleonExtensionFactory.java 0.00% <0.00%> (ø)
.../java/dev/hypera/chameleon/util/ChameleonUtil.java 100.00% <ø> (+50.00%) ⬆️
.../java/dev/hypera/chameleon/event/EventBusImpl.java 74.07% <50.00%> (-1.37%) ⬇️
.../src/main/java/dev/hypera/chameleon/Chameleon.java 66.66% <70.00%> (+42.42%) ⬆️
...era/chameleon/event/common/ChameleonLoadEvent.java 75.00% <75.00%> (ø)
...pera/chameleon/extension/ExtensionManagerImpl.java 96.42% <96.42%> (ø)
...dev/hypera/chameleon/util/graph/DirectedGraph.java 97.50% <97.50%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

@joshuasing joshuasing marked this pull request as draft March 8, 2023 07:27
@joshuasing joshuasing marked this pull request as ready for review March 13, 2023 16:34
@joshuasing joshuasing merged commit 3ab8972 into main Apr 4, 2023
@joshuasing joshuasing deleted the extensions-v2 branch April 4, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: extensions type: enhancement This is a feature request or a pull request that adds a feature type: feature This adds a new feature type: refactor This refactors existing code type: test This involves updating, adding or removing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions v2
2 participants