Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vertexai): Add GCP Vertex AI providers with generation and chat … #352

Merged
merged 1 commit into from
Sep 4, 2023
Merged

feat(vertexai): Add GCP Vertex AI providers with generation and chat … #352

merged 1 commit into from
Sep 4, 2023

Conversation

fvaleye
Copy link
Contributor

@fvaleye fvaleye commented Sep 4, 2023

Description

  • Add the Generation and Chat models from GCP VertexAI
  • Using the GOOGLE_APPLICATION_CREDENTIALS environment variables, the playground is available for chat and generation LLM models of VertexAI
  • Only common parameters are available: temperature and max_output_tokens

@fvaleye fvaleye force-pushed the feature/add-vertexai-llm-provider branch from 68579bc to cc2532d Compare September 4, 2023 09:06
willydouhard
willydouhard requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Almost ready to merge, few comments to address first

backend/chainlit/playground/providers/vertexai.py Outdated Show resolved Hide resolved
backend/chainlit/playground/providers/vertexai.py Outdated Show resolved Hide resolved
backend/chainlit/playground/providers/vertexai.py Outdated Show resolved Hide resolved
backend/chainlit/playground/providers/vertexai.py Outdated Show resolved Hide resolved
@willydouhard
Copy link
Collaborator

Screenshot 2023-09-04 at 12 19 44 My py caught an error import, I think it should import from `vertexai.py` and not `openai.py`

@fvaleye fvaleye force-pushed the feature/add-vertexai-llm-provider branch from cc2532d to 6c9d42c Compare September 4, 2023 13:09
@fvaleye
Copy link
Contributor Author

fvaleye commented Sep 4, 2023

Screenshot 2023-09-04 at 12 19 44 My py caught an error import, I think it should import from vertexai.py and not openai.py

Thanks. I fixed it!

@fvaleye fvaleye force-pushed the feature/add-vertexai-llm-provider branch from 6c9d42c to 8c5e9ee Compare September 4, 2023 14:47
willydouhard
willydouhard approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willydouhard willydouhard merged commit 9bd8694 into Chainlit:main Sep 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willydouhard willydouhard willydouhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvaleye @willydouhard