Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
-sse4_crc32
has comparable performance to@node-rs/crc32
(or better in some cases) but without memory issue (see napi-rs/node-rs#655)- This is a backup solution in case it takes time to resolve that issueDescription
- Switch tosse4_crc32
@node-rs/crc32
v1.6.0Benchmark result
sse4_crc32
wins for smaller data but lose from 1MB so in general, they are comparable