Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: migrate to biomejs from eslint #7108

Merged
merged 35 commits into from
Oct 10, 2024
Merged

deps: migrate to biomejs from eslint #7108

Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
93d34a3
Replace eslint with biomejs
nazarhussain May 21, 2024
e778bd5
Update the inclusion of word
nazarhussain May 21, 2024
20d3bc0
Fix the formatting
nazarhussain May 21, 2024
a7594a2
Update the lint task to do all checks
nazarhussain May 21, 2024
43857a8
Update biome rules from eslint config
nazarhussain May 21, 2024
1c482d1
Replace eslint with biomejs
nazarhussain May 21, 2024
cab1cde
Update the inclusion of word
nazarhussain May 21, 2024
9d689e6
Fix the formatting
nazarhussain May 21, 2024
b2d3c90
Update the lint task to do all checks
nazarhussain May 21, 2024
360edff
Update biome rules from eslint config
nazarhussain May 21, 2024
78d3dd9
Fix all lint issues
nazarhussain Sep 25, 2024
bf2f1c0
Merge branch 'nh/biomejs' of github.com:ChainSafe/lodestar into nh/bi…
nazarhussain Sep 25, 2024
a457a59
Fix formatting
nazarhussain Sep 25, 2024
5036812
Add extension recomendation for vscode
nazarhussain Sep 25, 2024
95f6f9e
Enable recommended rules
nazarhussain Sep 25, 2024
4704ad3
Enable rule noUselessSwitchCase
nazarhussain Sep 25, 2024
5615a91
Enable rule noUselessConstructor
nazarhussain Sep 25, 2024
6f2ae80
Fix the types
nazarhussain Sep 25, 2024
dc09341
Fix unit tests
nazarhussain Sep 25, 2024
0345e51
Enforce import extensions
nazarhussain Oct 1, 2024
3264694
Update the cli command
nazarhussain Oct 1, 2024
c5f3be6
Enforce useConsistentMemberAccessibility
nazarhussain Oct 1, 2024
7e9b1a2
Update rules
nazarhussain Oct 1, 2024
03806a0
Fix rules
nazarhussain Oct 1, 2024
7f2c715
Upgrade biomejs to latest version
nazarhussain Oct 1, 2024
5c507a5
Update the rules
nazarhussain Oct 2, 2024
3a36547
Update and format the config file
nazarhussain Oct 2, 2024
f7871fb
Merge branch 'unstable' into nh/biomejs
nazarhussain Oct 8, 2024
87bc3af
Fix types break during merge
nazarhussain Oct 8, 2024
0a6e24e
Fix unused check
nazarhussain Oct 8, 2024
6e0e85b
Add comment for explicit-return-type
nazarhussain Oct 8, 2024
dd79326
Remove eslint file
nazarhussain Oct 8, 2024
fba83fa
Add _e objects for empty catch blocks
nazarhussain Oct 9, 2024
95bc933
Update formatter config
nazarhussain Oct 9, 2024
ddd66bb
Fix formatting
nazarhussain Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ jobs:
- name: Assert ESM module exports
run: node scripts/assert_exports.mjs

- name: Assert eslintrc rules sorted
run: scripts/assert_eslintrc_sorted.mjs

type-checks:
name: Type Checks
needs: build
Expand Down
5 changes: 5 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"recommendations": [
"biomejs.biome"
]
}
1 change: 0 additions & 1 deletion .wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ EIPs
EL
ENR
ENRs
ESLint
ETH
Edgington
Erigon
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ To run tests:
- :test_tube: Run `yarn test:spec` for spec tests.
- :test_tube: Run `yarn test` to run all tests.
- :test_tube: Run `yarn check-types` to check TypeScript types.
- :test_tube: Run `yarn lint` to run the linter (ESLint).
- :test_tube: Run `yarn lint` to run the linter.

Note that to run `test:e2e`, first ensure that the environment is correctly setup by running the `run_e2e_env.sh` script. This script requires a running docker engine.

Expand Down
Loading
Loading