chore: add eslint rule to restrict global fetch #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6500 +/- ##
=========================================
Coverage 61.72% 61.72%
=========================================
Files 555 555
Lines 58204 58206 +2
Branches 1843 1844 +1
=========================================
+ Hits 35926 35929 +3
+ Misses 22239 22238 -1
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
requested changes
Feb 28, 2024
| @@ -5,6 +5,7 @@ | |||
| */ | |||
| async function wrappedFetch(url: string | URL, init?: RequestInit): Promise<Response> { | |||
| try { | |||
| // eslint-disable-next-line no-restricted-globals | |||
There was a problem hiding this comment.
Please add a comment here which explains why disabling this rule is important here. I believe that's the only place we need to use native fetch.
There was a problem hiding this comment.
I added a comment but obviously the function can't call itself, so I thought it is kinda self explanatory here
nazarhussain
approved these changes
Feb 29, 2024
|
🎉 This PR is included in v1.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should make sure that we don't accidentally use native fetch without error wrapper.
Description
Add eslint rule to restrict global fetch
Related #6497