deps: update typescript to 5.3.3 #6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
reviewed
Feb 27, 2024
| @@ -13,7 +13,7 @@ export async function fetchNearestBlock( | |||
| ): Promise<capella.SignedBeaconBlock> { | |||
| const res = await api.beacon.getBlockV2(slot); | |||
|
|
|||
| if (res.ok) return res.response.data; | |||
| if (res.ok) return res.response.data as capella.SignedBeaconBlock; | |||
There was a problem hiding this comment.
The new typescript found this type issue?
There was a problem hiding this comment.
yes the newer version is strict when returning union type.
jeluard
previously approved these changes
Feb 27, 2024
|
For reference the biggest change in this version is actually some technical debt on the Typescript side. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6491 +/- ##
=========================================
Coverage 61.72% 61.72%
=========================================
Files 555 555
Lines 58204 58204
Branches 1839 1844 +5
=========================================
+ Hits 35925 35927 +2
+ Misses 22240 22238 -2
Partials 39 39 |
wemeetagain
approved these changes
Feb 27, 2024
|
🎉 This PR is included in v1.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep the dependencies up-to-date.
Description
Update Typescript to latest 5.3.3.
Steps to test or reproduce