-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase bodyLimit of the beacon api server #6476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6476 +/- ##
=========================================
Coverage 61.72% 61.72%
=========================================
Files 555 555
Lines 58204 58204
Branches 1839 1839
=========================================
Hits 35925 35925
Misses 22240 22240
Partials 39 39 |
philknows
previously approved these changes
Feb 23, 2024
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Feb 23, 2024
nflaig
approved these changes
Feb 24, 2024
🎉 This PR is included in v1.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EF devops reported that while testing https://dora.dencun-msf-1.ethpandaops.io/slots
probably 7Mb blocks + blobs are pushing over the limit, locally fix seems to be working on resolving this error but there is another issue of latency between val<>beacon for these big blocks which needs to be looked as as well, but its an independent issue to be tackled (currently looking into that)
@philknows @wemeetagain we might need to cut a patch release with this