Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos in un-/subscribing attnets logs #6454

Merged
merged 1 commit into from
Feb 20, 2024
Merged

chore: fix typos in un-/subscribing attnets logs #6454

merged 1 commit into from
Feb 20, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 19, 2024

Motivation

Just some typos I picked up when looking into #6319, and since those are info logs, I feel like it's worth updating them.

Description

Fix typos in un-/subscribing attnets logs

@nflaig nflaig requested a review from a team as a code owner February 19, 2024 20:44
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #6454 (2c8bb4b) into unstable (290c301) will decrease coverage by 0.08%.
Report is 2 commits behind head on unstable.
The diff coverage is 0.00%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6454      +/-   ##
============================================
- Coverage     61.71%   61.63%   -0.08%     
============================================
  Files           553      553              
  Lines         57900    57975      +75     
  Branches       1832     1832              
============================================
  Hits          35733    35733              
- Misses        22130    22205      +75     
  Partials         37       37

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f902f22 Previous: efb684a Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 737.00 us/op 697.65 us/op 1.06
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 110.55 us/op 77.489 us/op 1.43
BLS verify - blst-native 1.3284 ms/op 1.2474 ms/op 1.06
BLS verifyMultipleSignatures 3 - blst-native 2.7961 ms/op 2.6167 ms/op 1.07
BLS verifyMultipleSignatures 8 - blst-native 6.0093 ms/op 5.7342 ms/op 1.05
BLS verifyMultipleSignatures 32 - blst-native 22.750 ms/op 20.982 ms/op 1.08
BLS verifyMultipleSignatures 64 - blst-native 44.576 ms/op 41.303 ms/op 1.08
BLS verifyMultipleSignatures 128 - blst-native 89.011 ms/op 82.015 ms/op 1.09
BLS deserializing 10000 signatures 969.91 ms/op 887.36 ms/op 1.09
BLS deserializing 100000 signatures 9.5808 s/op 9.1057 s/op 1.05
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3752 ms/op 1.3087 ms/op 1.05
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6618 ms/op 1.5334 ms/op 1.08
BLS verifyMultipleSignatures - same message - 32 - blst-native 3.1218 ms/op 2.7232 ms/op 1.15
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.4868 ms/op 4.3782 ms/op 0.80
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.6819 ms/op 5.3888 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 28.597 us/op 24.695 us/op 1.16
BLS aggregatePubkeys 128 - blst-native 102.48 us/op 96.912 us/op 1.06
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 53.808 ms/op 47.999 ms/op 1.12
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 50.654 ms/op 42.317 ms/op 1.20
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 35.084 ms/op 30.178 ms/op 1.16
getSlashingsAndExits - default max 175.76 us/op 174.88 us/op 1.01
getSlashingsAndExits - 2k 440.17 us/op 375.66 us/op 1.17
proposeBlockBody type=full, size=empty 5.4578 ms/op 4.8396 ms/op 1.13
isKnown best case - 1 super set check 289.00 ns/op 288.00 ns/op 1.00
isKnown normal case - 2 super set checks 292.00 ns/op 280.00 ns/op 1.04
isKnown worse case - 16 super set checks 283.00 ns/op 282.00 ns/op 1.00
CheckpointStateCache - add get delete 4.9520 us/op 4.7720 us/op 1.04
validate api signedAggregateAndProof - struct 2.6608 ms/op 2.6652 ms/op 1.00
validate gossip signedAggregateAndProof - struct 2.7446 ms/op 2.6773 ms/op 1.03
validate gossip attestation - vc 640000 1.3322 ms/op 1.3090 ms/op 1.02
batch validate gossip attestation - vc 640000 - chunk 32 158.83 us/op 154.48 us/op 1.03
batch validate gossip attestation - vc 640000 - chunk 64 146.14 us/op 139.15 us/op 1.05
batch validate gossip attestation - vc 640000 - chunk 128 138.01 us/op 133.68 us/op 1.03
batch validate gossip attestation - vc 640000 - chunk 256 136.60 us/op 128.75 us/op 1.06
pickEth1Vote - no votes 1.2030 ms/op 1.3222 ms/op 0.91
pickEth1Vote - max votes 15.319 ms/op 11.619 ms/op 1.32
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.694 ms/op 23.581 ms/op 0.75
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 36.129 ms/op 29.917 ms/op 1.21
pickEth1Vote - Eth1Data fastSerialize value x2048 640.84 us/op 606.84 us/op 1.06
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.0056 ms/op 6.7329 ms/op 0.74
bytes32 toHexString 510.00 ns/op 512.00 ns/op 1.00
bytes32 Buffer.toString(hex) 302.00 ns/op 286.00 ns/op 1.06
bytes32 Buffer.toString(hex) from Uint8Array 431.00 ns/op 438.00 ns/op 0.98
bytes32 Buffer.toString(hex) + 0x 309.00 ns/op 289.00 ns/op 1.07
Object access 1 prop 0.18000 ns/op 0.16100 ns/op 1.12
Map access 1 prop 0.15700 ns/op 0.14300 ns/op 1.10
Object get x1000 7.1660 ns/op 7.1500 ns/op 1.00
Map get x1000 0.78600 ns/op 0.77600 ns/op 1.01
Object set x1000 51.090 ns/op 51.867 ns/op 0.99
Map set x1000 41.201 ns/op 45.226 ns/op 0.91
Return object 10000 times 0.23810 ns/op 0.24100 ns/op 0.99
Throw Error 10000 times 3.9144 us/op 3.8534 us/op 1.02
fastMsgIdFn sha256 / 200 bytes 3.3690 us/op 3.2940 us/op 1.02
fastMsgIdFn h32 xxhash / 200 bytes 293.00 ns/op 289.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 200 bytes 345.00 ns/op 347.00 ns/op 0.99
fastMsgIdFn sha256 / 1000 bytes 11.340 us/op 11.170 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 415.00 ns/op 464.00 ns/op 0.89
fastMsgIdFn h64 xxhash / 1000 bytes 417.00 ns/op 441.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 103.83 us/op 103.75 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9430 us/op 2.0220 us/op 0.96
fastMsgIdFn h64 xxhash / 10000 bytes 1.3110 us/op 1.3750 us/op 0.95
send data - 1000 256B messages 18.527 ms/op 21.440 ms/op 0.86
send data - 1000 512B messages 27.391 ms/op 23.958 ms/op 1.14
send data - 1000 1024B messages 40.470 ms/op 43.625 ms/op 0.93
send data - 1000 1200B messages 37.184 ms/op 37.256 ms/op 1.00
send data - 1000 2048B messages 50.075 ms/op 49.670 ms/op 1.01
send data - 1000 4096B messages 27.770 ms/op 44.322 ms/op 0.63
send data - 1000 16384B messages 117.34 ms/op 114.42 ms/op 1.03
send data - 1000 65536B messages 452.82 ms/op 505.02 ms/op 0.90
enrSubnets - fastDeserialize 64 bits 1.6050 us/op 1.5210 us/op 1.06
enrSubnets - ssz BitVector 64 bits 509.00 ns/op 478.00 ns/op 1.06
enrSubnets - fastDeserialize 4 bits 216.00 ns/op 185.00 ns/op 1.17
enrSubnets - ssz BitVector 4 bits 516.00 ns/op 504.00 ns/op 1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0 117.88 us/op 111.92 us/op 1.05
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 150.59 us/op 141.58 us/op 1.06
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 198.93 us/op 184.57 us/op 1.08
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 343.90 us/op 331.33 us/op 1.04
prioritizePeers score 0:0 att 64-1 sync 4-1 380.45 us/op 400.29 us/op 0.95
array of 16000 items push then shift 1.7289 us/op 1.6985 us/op 1.02
LinkedList of 16000 items push then shift 9.8200 ns/op 9.2250 ns/op 1.06
array of 16000 items push then pop 112.97 ns/op 108.40 ns/op 1.04
LinkedList of 16000 items push then pop 9.0220 ns/op 8.7430 ns/op 1.03
array of 24000 items push then shift 2.4611 us/op 2.5359 us/op 0.97
LinkedList of 24000 items push then shift 9.3780 ns/op 8.9940 ns/op 1.04
array of 24000 items push then pop 138.49 ns/op 143.51 ns/op 0.96
LinkedList of 24000 items push then pop 8.9400 ns/op 8.6720 ns/op 1.03
intersect bitArray bitLen 8 6.0310 ns/op 5.7940 ns/op 1.04
intersect array and set length 8 65.495 ns/op 65.445 ns/op 1.00
intersect bitArray bitLen 128 36.624 ns/op 35.612 ns/op 1.03
intersect array and set length 128 882.40 ns/op 911.77 ns/op 0.97
bitArray.getTrueBitIndexes() bitLen 128 1.5640 us/op 1.6320 us/op 0.96
bitArray.getTrueBitIndexes() bitLen 248 2.8280 us/op 2.7040 us/op 1.05
bitArray.getTrueBitIndexes() bitLen 512 5.3140 us/op 5.4520 us/op 0.97
Buffer.concat 32 items 977.00 ns/op 987.00 ns/op 0.99
Uint8Array.set 32 items 1.7840 us/op 1.7920 us/op 1.00
Set add up to 64 items then delete first 4.5575 us/op 4.7651 us/op 0.96
OrderedSet add up to 64 items then delete first 6.0227 us/op 5.6861 us/op 1.06
Set add up to 64 items then delete last 4.9005 us/op 4.9010 us/op 1.00
OrderedSet add up to 64 items then delete last 6.2607 us/op 6.6721 us/op 0.94
Set add up to 64 items then delete middle 4.9556 us/op 5.1306 us/op 0.97
OrderedSet add up to 64 items then delete middle 7.5103 us/op 8.0169 us/op 0.94
Set add up to 128 items then delete first 10.035 us/op 9.2276 us/op 1.09
OrderedSet add up to 128 items then delete first 13.210 us/op 12.416 us/op 1.06
Set add up to 128 items then delete last 9.7549 us/op 9.3763 us/op 1.04
OrderedSet add up to 128 items then delete last 12.449 us/op 11.597 us/op 1.07
Set add up to 128 items then delete middle 9.7196 us/op 9.0817 us/op 1.07
OrderedSet add up to 128 items then delete middle 18.212 us/op 16.960 us/op 1.07
Set add up to 256 items then delete first 20.263 us/op 18.913 us/op 1.07
OrderedSet add up to 256 items then delete first 27.233 us/op 25.112 us/op 1.08
Set add up to 256 items then delete last 19.543 us/op 18.431 us/op 1.06
OrderedSet add up to 256 items then delete last 24.490 us/op 23.377 us/op 1.05
Set add up to 256 items then delete middle 19.196 us/op 18.341 us/op 1.05
OrderedSet add up to 256 items then delete middle 49.182 us/op 46.453 us/op 1.06
transfer serialized Status (84 B) 1.8150 us/op 1.6390 us/op 1.11
copy serialized Status (84 B) 1.3280 us/op 1.2710 us/op 1.04
transfer serialized SignedVoluntaryExit (112 B) 2.0220 us/op 1.7640 us/op 1.15
copy serialized SignedVoluntaryExit (112 B) 1.4400 us/op 1.2940 us/op 1.11
transfer serialized ProposerSlashing (416 B) 2.6300 us/op 1.8970 us/op 1.39
copy serialized ProposerSlashing (416 B) 2.1410 us/op 2.3340 us/op 0.92
transfer serialized Attestation (485 B) 2.1520 us/op 2.5480 us/op 0.84
copy serialized Attestation (485 B) 2.4270 us/op 2.6680 us/op 0.91
transfer serialized AttesterSlashing (33232 B) 2.4340 us/op 2.0820 us/op 1.17
copy serialized AttesterSlashing (33232 B) 6.2770 us/op 5.8260 us/op 1.08
transfer serialized Small SignedBeaconBlock (128000 B) 3.1220 us/op 2.3220 us/op 1.34
copy serialized Small SignedBeaconBlock (128000 B) 21.918 us/op 15.494 us/op 1.41
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4410 us/op 2.6170 us/op 1.31
copy serialized Avg SignedBeaconBlock (200000 B) 24.421 us/op 23.280 us/op 1.05
transfer serialized BlobsSidecar (524380 B) 3.6290 us/op 2.7070 us/op 1.34
copy serialized BlobsSidecar (524380 B) 81.049 us/op 87.278 us/op 0.93
transfer serialized Big SignedBeaconBlock (1000000 B) 3.0900 us/op 2.7380 us/op 1.13
copy serialized Big SignedBeaconBlock (1000000 B) 174.34 us/op 168.08 us/op 1.04
pass gossip attestations to forkchoice per slot 4.0331 ms/op 4.3541 ms/op 0.93
forkChoice updateHead vc 100000 bc 64 eq 0 709.60 us/op 691.76 us/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 0 4.3853 ms/op 4.6346 ms/op 0.95
forkChoice updateHead vc 1000000 bc 64 eq 0 7.6842 ms/op 6.9423 ms/op 1.11
forkChoice updateHead vc 600000 bc 320 eq 0 4.4395 ms/op 4.1285 ms/op 1.08
forkChoice updateHead vc 600000 bc 1200 eq 0 4.5312 ms/op 4.2143 ms/op 1.08
forkChoice updateHead vc 600000 bc 7200 eq 0 5.7077 ms/op 5.2216 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 1000 11.631 ms/op 11.049 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 10000 12.447 ms/op 11.732 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 300000 17.419 ms/op 15.323 ms/op 1.14
computeDeltas 500000 validators 300 proto nodes 7.0285 ms/op 6.5420 ms/op 1.07
computeDeltas 500000 validators 1200 proto nodes 6.8663 ms/op 6.3806 ms/op 1.08
computeDeltas 500000 validators 7200 proto nodes 6.7247 ms/op 6.2551 ms/op 1.08
computeDeltas 750000 validators 300 proto nodes 9.9919 ms/op 9.5757 ms/op 1.04
computeDeltas 750000 validators 1200 proto nodes 9.7155 ms/op 9.7188 ms/op 1.00
computeDeltas 750000 validators 7200 proto nodes 10.138 ms/op 9.7933 ms/op 1.04
computeDeltas 1400000 validators 300 proto nodes 19.631 ms/op 18.590 ms/op 1.06
computeDeltas 1400000 validators 1200 proto nodes 19.871 ms/op 19.032 ms/op 1.04
computeDeltas 1400000 validators 7200 proto nodes 20.243 ms/op 18.276 ms/op 1.11
computeDeltas 2100000 validators 300 proto nodes 29.684 ms/op 26.697 ms/op 1.11
computeDeltas 2100000 validators 1200 proto nodes 29.347 ms/op 27.535 ms/op 1.07
computeDeltas 2100000 validators 7200 proto nodes 29.629 ms/op 28.111 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei normalcase 2.4457 ms/op 1.9996 ms/op 1.22
altair processAttestation - 250000 vs - 7PWei worstcase 3.7694 ms/op 2.9370 ms/op 1.28
altair processAttestation - setStatus - 1/6 committees join 160.52 us/op 140.12 us/op 1.15
altair processAttestation - setStatus - 1/3 committees join 326.18 us/op 276.26 us/op 1.18
altair processAttestation - setStatus - 1/2 committees join 396.65 us/op 367.22 us/op 1.08
altair processAttestation - setStatus - 2/3 committees join 509.53 us/op 458.84 us/op 1.11
altair processAttestation - setStatus - 4/5 committees join 688.49 us/op 654.68 us/op 1.05
altair processAttestation - setStatus - 100% committees join 803.51 us/op 761.25 us/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase 10.202 ms/op 9.5685 ms/op 1.07
altair processBlock - 250000 vs - 7PWei normalcase hashState 35.648 ms/op 32.780 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase 41.536 ms/op 35.516 ms/op 1.17
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.566 ms/op 88.418 ms/op 1.13
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2831 ms/op 2.6453 ms/op 1.24
phase0 processBlock - 250000 vs - 7PWei worstcase 32.261 ms/op 27.525 ms/op 1.17
altair processEth1Data - 250000 vs - 7PWei normalcase 617.92 us/op 548.64 us/op 1.13
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 18.328 us/op 7.2460 us/op 2.53
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 67.347 us/op 57.374 us/op 1.17
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 10.390 us/op 12.871 us/op 0.81
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 11.608 us/op 7.7030 us/op 1.51
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 185.90 us/op 150.49 us/op 1.24
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5336 ms/op 1.1794 ms/op 1.30
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 3.0560 ms/op 1.4610 ms/op 2.09
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.8845 ms/op 1.6313 ms/op 1.77
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.7798 ms/op 3.2789 ms/op 1.15
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.3246 ms/op 2.3827 ms/op 0.98
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.7106 ms/op 5.6026 ms/op 1.02
Tree 40 250000 create 378.43 ms/op 352.57 ms/op 1.07
Tree 40 250000 get(125000) 211.59 ns/op 196.44 ns/op 1.08
Tree 40 250000 set(125000) 1.1016 us/op 1.0270 us/op 1.07
Tree 40 250000 toArray() 22.108 ms/op 20.038 ms/op 1.10
Tree 40 250000 iterate all - toArray() + loop 21.940 ms/op 20.691 ms/op 1.06
Tree 40 250000 iterate all - get(i) 72.410 ms/op 67.028 ms/op 1.08
MutableVector 250000 create 18.965 ms/op 13.728 ms/op 1.38
MutableVector 250000 get(125000) 6.8540 ns/op 6.6870 ns/op 1.02
MutableVector 250000 set(125000) 311.58 ns/op 281.88 ns/op 1.11
MutableVector 250000 toArray() 3.8756 ms/op 3.3387 ms/op 1.16
MutableVector 250000 iterate all - toArray() + loop 3.8255 ms/op 3.7943 ms/op 1.01
MutableVector 250000 iterate all - get(i) 1.6074 ms/op 1.5364 ms/op 1.05
Array 250000 create 3.1541 ms/op 3.5763 ms/op 0.88
Array 250000 clone - spread 1.4233 ms/op 1.4341 ms/op 0.99
Array 250000 get(125000) 1.1710 ns/op 1.1750 ns/op 1.00
Array 250000 set(125000) 4.7230 ns/op 4.4770 ns/op 1.05
Array 250000 iterate all - loop 168.59 us/op 165.13 us/op 1.02
effectiveBalanceIncrements clone Uint8Array 300000 37.296 us/op 40.824 us/op 0.91
effectiveBalanceIncrements clone MutableVector 300000 428.00 ns/op 458.00 ns/op 0.93
effectiveBalanceIncrements rw all Uint8Array 300000 207.39 us/op 201.65 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 93.054 ms/op 99.200 ms/op 0.94
phase0 afterProcessEpoch - 250000 vs - 7PWei 116.93 ms/op 116.19 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 42.670 ms/op 39.152 ms/op 1.09
altair processEpoch - mainnet_e81889 599.27 ms/op 544.26 ms/op 1.10
mainnet_e81889 - altair beforeProcessEpoch 87.946 ms/op 90.585 ms/op 0.97
mainnet_e81889 - altair processJustificationAndFinalization 23.337 us/op 15.638 us/op 1.49
mainnet_e81889 - altair processInactivityUpdates 5.5999 ms/op 6.2163 ms/op 0.90
mainnet_e81889 - altair processRewardsAndPenalties 78.416 ms/op 64.901 ms/op 1.21
mainnet_e81889 - altair processRegistryUpdates 4.1720 us/op 4.5520 us/op 0.92
mainnet_e81889 - altair processSlashings 775.00 ns/op 1.0020 us/op 0.77
mainnet_e81889 - altair processEth1DataReset 1.0060 us/op 909.00 ns/op 1.11
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.6570 ms/op 2.4650 ms/op 1.08
mainnet_e81889 - altair processSlashingsReset 5.2250 us/op 5.8400 us/op 0.89
mainnet_e81889 - altair processRandaoMixesReset 6.6540 us/op 5.5300 us/op 1.20
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2090 us/op 715.00 ns/op 1.69
mainnet_e81889 - altair processParticipationFlagUpdates 2.0730 us/op 1.9170 us/op 1.08
mainnet_e81889 - altair processSyncCommitteeUpdates 737.00 ns/op 647.00 ns/op 1.14
mainnet_e81889 - altair afterProcessEpoch 116.60 ms/op 119.23 ms/op 0.98
capella processEpoch - mainnet_e217614 2.2738 s/op 2.0907 s/op 1.09
mainnet_e217614 - capella beforeProcessEpoch 515.74 ms/op 482.39 ms/op 1.07
mainnet_e217614 - capella processJustificationAndFinalization 32.702 us/op 14.278 us/op 2.29
mainnet_e217614 - capella processInactivityUpdates 17.820 ms/op 21.228 ms/op 0.84
mainnet_e217614 - capella processRewardsAndPenalties 422.08 ms/op 399.91 ms/op 1.06
mainnet_e217614 - capella processRegistryUpdates 34.912 us/op 20.899 us/op 1.67
mainnet_e217614 - capella processSlashings 890.00 ns/op 567.00 ns/op 1.57
mainnet_e217614 - capella processEth1DataReset 706.00 ns/op 464.00 ns/op 1.52
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.5526 ms/op 5.3251 ms/op 0.85
mainnet_e217614 - capella processSlashingsReset 4.8730 us/op 3.0670 us/op 1.59
mainnet_e217614 - capella processRandaoMixesReset 7.5330 us/op 4.4630 us/op 1.69
mainnet_e217614 - capella processHistoricalRootsUpdate 923.00 ns/op 504.00 ns/op 1.83
mainnet_e217614 - capella processParticipationFlagUpdates 2.6100 us/op 1.7130 us/op 1.52
mainnet_e217614 - capella afterProcessEpoch 281.00 ms/op 298.39 ms/op 0.94
phase0 processEpoch - mainnet_e58758 531.82 ms/op 480.35 ms/op 1.11
mainnet_e58758 - phase0 beforeProcessEpoch 141.51 ms/op 134.80 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 27.097 us/op 16.134 us/op 1.68
mainnet_e58758 - phase0 processRewardsAndPenalties 56.877 ms/op 52.645 ms/op 1.08
mainnet_e58758 - phase0 processRegistryUpdates 16.061 us/op 12.711 us/op 1.26
mainnet_e58758 - phase0 processSlashings 969.00 ns/op 609.00 ns/op 1.59
mainnet_e58758 - phase0 processEth1DataReset 682.00 ns/op 437.00 ns/op 1.56
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1621 ms/op 1.2118 ms/op 1.78
mainnet_e58758 - phase0 processSlashingsReset 4.1410 us/op 4.5520 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 6.5000 us/op 4.0530 us/op 1.60
mainnet_e58758 - phase0 processHistoricalRootsUpdate 723.00 ns/op 454.00 ns/op 1.59
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.3300 us/op 3.8690 us/op 1.64
mainnet_e58758 - phase0 afterProcessEpoch 91.830 ms/op 95.710 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5902 ms/op 1.3896 ms/op 1.86
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4674 ms/op 1.5153 ms/op 1.63
altair processInactivityUpdates - 250000 normalcase 33.552 ms/op 28.230 ms/op 1.19
altair processInactivityUpdates - 250000 worstcase 38.025 ms/op 22.473 ms/op 1.69
phase0 processRegistryUpdates - 250000 normalcase 13.584 us/op 11.704 us/op 1.16
phase0 processRegistryUpdates - 250000 badcase_full_deposits 755.09 us/op 468.15 us/op 1.61
phase0 processRegistryUpdates - 250000 worstcase 0.5 149.82 ms/op 139.83 ms/op 1.07
altair processRewardsAndPenalties - 250000 normalcase 69.497 ms/op 47.891 ms/op 1.45
altair processRewardsAndPenalties - 250000 worstcase 74.413 ms/op 57.232 ms/op 1.30
phase0 getAttestationDeltas - 250000 normalcase 8.7232 ms/op 11.398 ms/op 0.77
phase0 getAttestationDeltas - 250000 worstcase 8.7547 ms/op 11.416 ms/op 0.77
phase0 processSlashings - 250000 worstcase 133.36 us/op 112.88 us/op 1.18
altair processSyncCommitteeUpdates - 250000 158.28 ms/op 162.82 ms/op 0.97
BeaconState.hashTreeRoot - No change 504.00 ns/op 627.00 ns/op 0.80
BeaconState.hashTreeRoot - 1 full validator 150.63 us/op 135.91 us/op 1.11
BeaconState.hashTreeRoot - 32 full validator 1.6436 ms/op 1.3099 ms/op 1.25
BeaconState.hashTreeRoot - 512 full validator 19.291 ms/op 14.660 ms/op 1.32
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 202.25 us/op 157.85 us/op 1.28
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4844 ms/op 2.1863 ms/op 1.14
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 28.972 ms/op 32.959 ms/op 0.88
BeaconState.hashTreeRoot - 1 balances 153.86 us/op 138.41 us/op 1.11
BeaconState.hashTreeRoot - 32 balances 1.3591 ms/op 1.2724 ms/op 1.07
BeaconState.hashTreeRoot - 512 balances 13.370 ms/op 14.375 ms/op 0.93
BeaconState.hashTreeRoot - 250000 balances 241.01 ms/op 200.34 ms/op 1.20
aggregationBits - 2048 els - zipIndexesInBitList 17.576 us/op 21.644 us/op 0.81
byteArrayEquals 32 77.630 ns/op 75.611 ns/op 1.03
Buffer.compare 32 57.891 ns/op 55.813 ns/op 1.04
byteArrayEquals 1024 2.1075 us/op 2.0574 us/op 1.02
Buffer.compare 1024 72.342 ns/op 70.522 ns/op 1.03
byteArrayEquals 16384 33.566 us/op 32.795 us/op 1.02
Buffer.compare 16384 272.25 ns/op 278.91 ns/op 0.98
byteArrayEquals 123687377 248.85 ms/op 248.89 ms/op 1.00
Buffer.compare 123687377 6.2758 ms/op 7.8375 ms/op 0.80
byteArrayEquals 32 - diff last byte 72.590 ns/op 75.749 ns/op 0.96
Buffer.compare 32 - diff last byte 56.847 ns/op 58.049 ns/op 0.98
byteArrayEquals 1024 - diff last byte 2.0753 us/op 2.0572 us/op 1.01
Buffer.compare 1024 - diff last byte 73.142 ns/op 73.985 ns/op 0.99
byteArrayEquals 16384 - diff last byte 33.086 us/op 32.789 us/op 1.01
Buffer.compare 16384 - diff last byte 250.12 ns/op 263.59 ns/op 0.95
byteArrayEquals 123687377 - diff last byte 250.21 ms/op 251.24 ms/op 1.00
Buffer.compare 123687377 - diff last byte 6.7855 ms/op 8.4139 ms/op 0.81
byteArrayEquals 32 - random bytes 5.4880 ns/op 6.1190 ns/op 0.90
Buffer.compare 32 - random bytes 61.135 ns/op 63.479 ns/op 0.96
byteArrayEquals 1024 - random bytes 5.2300 ns/op 6.4640 ns/op 0.81
Buffer.compare 1024 - random bytes 60.940 ns/op 63.146 ns/op 0.97
byteArrayEquals 16384 - random bytes 5.1940 ns/op 6.1640 ns/op 0.84
Buffer.compare 16384 - random bytes 62.141 ns/op 63.207 ns/op 0.98
byteArrayEquals 123687377 - random bytes 8.5100 ns/op 8.9800 ns/op 0.95
Buffer.compare 123687377 - random bytes 64.930 ns/op 75.330 ns/op 0.86
regular array get 100000 times 44.387 us/op 45.960 us/op 0.97
wrappedArray get 100000 times 44.654 us/op 45.724 us/op 0.98
arrayWithProxy get 100000 times 14.250 ms/op 14.351 ms/op 0.99
ssz.Root.equals 53.896 ns/op 55.153 ns/op 0.98
byteArrayEquals 52.140 ns/op 54.385 ns/op 0.96
Buffer.compare 11.163 ns/op 11.888 ns/op 0.94
shuffle list - 16384 els 6.9956 ms/op 7.0834 ms/op 0.99
shuffle list - 250000 els 101.29 ms/op 104.92 ms/op 0.97
processSlot - 1 slots 18.239 us/op 18.167 us/op 1.00
processSlot - 32 slots 3.7335 ms/op 3.5536 ms/op 1.05
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 59.081 ms/op 61.706 ms/op 0.96
getCommitteeAssignments - req 1 vs - 250000 vc 2.4712 ms/op 2.6460 ms/op 0.93
getCommitteeAssignments - req 100 vs - 250000 vc 3.6043 ms/op 3.7269 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 4.0302 ms/op 4.1740 ms/op 0.97
findModifiedValidators - 10000 modified validators 532.86 ms/op 556.87 ms/op 0.96
findModifiedValidators - 1000 modified validators 415.90 ms/op 477.87 ms/op 0.87
findModifiedValidators - 100 modified validators 433.12 ms/op 467.41 ms/op 0.93
findModifiedValidators - 10 modified validators 434.29 ms/op 456.72 ms/op 0.95
findModifiedValidators - 1 modified validators 408.99 ms/op 454.11 ms/op 0.90
findModifiedValidators - no difference 423.58 ms/op 436.06 ms/op 0.97
compare ViewDUs 4.8617 s/op 5.0390 s/op 0.96
compare each validator Uint8Array 2.0419 s/op 1.8430 s/op 1.11
compare ViewDU to Uint8Array 1.1189 s/op 1.5333 s/op 0.73
migrate state 1000000 validators, 24 modified, 0 new 875.18 ms/op 979.83 ms/op 0.89
migrate state 1000000 validators, 1700 modified, 1000 new 1.1832 s/op 1.3197 s/op 0.90
migrate state 1000000 validators, 3400 modified, 2000 new 1.3666 s/op 1.4754 s/op 0.93
migrate state 1500000 validators, 24 modified, 0 new 822.29 ms/op 850.58 ms/op 0.97
migrate state 1500000 validators, 1700 modified, 1000 new 1.1131 s/op 1.2168 s/op 0.91
migrate state 1500000 validators, 3400 modified, 2000 new 1.4710 s/op 1.5389 s/op 0.96
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.1300 ns/op 5.1000 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 710.89 ns/op 659.45 ns/op 1.08
computeProposers - vc 250000 10.061 ms/op 9.4549 ms/op 1.06
computeEpochShuffling - vc 250000 107.63 ms/op 105.38 ms/op 1.02
getNextSyncCommittee - vc 250000 184.52 ms/op 169.28 ms/op 1.09
computeSigningRoot for AttestationData 27.459 us/op 34.040 us/op 0.81
hash AttestationData serialized data then Buffer.toString(base64) 2.4166 us/op 2.3768 us/op 1.02
toHexString serialized data 1.1703 us/op 1.5798 us/op 0.74
Buffer.toString(base64) 235.15 ns/op 252.92 ns/op 0.93

by benchmarkbot/action

@nflaig nflaig added this to the v1.16.0 milestone Feb 20, 2024
@wemeetagain wemeetagain merged commit 0a12b1b into unstable Feb 20, 2024
17 of 19 checks passed
@wemeetagain wemeetagain deleted the nflaig/fix-typos branch February 20, 2024 15:27
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain