Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): add clean:nm to root package.json #5616

Merged
merged 1 commit into from
Jun 6, 2023
Merged

chore(scripts): add clean:nm to root package.json #5616

merged 1 commit into from
Jun 6, 2023

Conversation

matthewkeil
Copy link
Member

Motivation

I find that when switching branches I occasionally need to delete the node_modules folder and re-run yarn. This is a helpful script I added and deleted a couple times. Figured may be helpful for others.

Description

1-line package.json script to delete the root and package node_modules folders

Steps to test or reproduce

from root folder

git checkout mkeil/clean-nm-script
yarn clean:nm

@matthewkeil matthewkeil requested a review from a team as a code owner June 6, 2023 14:59
nflaig
nflaig approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have found myself running that exact command as well.

Alternative solution to the "switching branches problem" would be to use git worktrees but not using them myself currently.

package.json Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 14b9193 Previous: 1cfb758 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 639.26 us/op 814.14 us/op 0.79
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 63.974 us/op 45.435 us/op 1.41
BLS verify - blst-native 1.3129 ms/op 1.1934 ms/op 1.10
BLS verifyMultipleSignatures 3 - blst-native 2.6775 ms/op 2.4443 ms/op 1.10
BLS verifyMultipleSignatures 8 - blst-native 5.7883 ms/op 5.2612 ms/op 1.10
BLS verifyMultipleSignatures 32 - blst-native 20.677 ms/op 18.955 ms/op 1.09
BLS aggregatePubkeys 32 - blst-native 27.886 us/op 25.432 us/op 1.10
BLS aggregatePubkeys 128 - blst-native 108.67 us/op 99.622 us/op 1.09
getAttestationsForBlock 64.649 ms/op 52.563 ms/op 1.23
isKnown best case - 1 super set check 284.00 ns/op 257.00 ns/op 1.11
isKnown normal case - 2 super set checks 268.00 ns/op 253.00 ns/op 1.06
isKnown worse case - 16 super set checks 268.00 ns/op 252.00 ns/op 1.06
CheckpointStateCache - add get delete 5.9600 us/op 4.7380 us/op 1.26
validate gossip signedAggregateAndProof - struct 2.9227 ms/op 2.7046 ms/op 1.08
validate gossip attestation - struct 1.3821 ms/op 1.2832 ms/op 1.08
pickEth1Vote - no votes 1.4416 ms/op 1.1807 ms/op 1.22
pickEth1Vote - max votes 13.263 ms/op 10.117 ms/op 1.31
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.031 ms/op 8.4659 ms/op 1.18
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 18.486 ms/op 15.167 ms/op 1.22
pickEth1Vote - Eth1Data fastSerialize value x2048 822.15 us/op 616.38 us/op 1.33
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.0657 ms/op 6.7409 ms/op 1.05
bytes32 toHexString 619.00 ns/op 481.00 ns/op 1.29
bytes32 Buffer.toString(hex) 435.00 ns/op 338.00 ns/op 1.29
bytes32 Buffer.toString(hex) from Uint8Array 643.00 ns/op 547.00 ns/op 1.18
bytes32 Buffer.toString(hex) + 0x 439.00 ns/op 339.00 ns/op 1.29
Object access 1 prop 0.20200 ns/op 0.16300 ns/op 1.24
Map access 1 prop 0.17900 ns/op 0.16000 ns/op 1.12
Object get x1000 7.5290 ns/op 6.3390 ns/op 1.19
Map get x1000 0.71100 ns/op 0.53000 ns/op 1.34
Object set x1000 73.724 ns/op 50.476 ns/op 1.46
Map set x1000 55.479 ns/op 42.318 ns/op 1.31
Return object 10000 times 0.26620 ns/op 0.23160 ns/op 1.15
Throw Error 10000 times 4.5370 us/op 4.0521 us/op 1.12
fastMsgIdFn sha256 / 200 bytes 3.7210 us/op 3.3380 us/op 1.11
fastMsgIdFn h32 xxhash / 200 bytes 327.00 ns/op 273.00 ns/op 1.20
fastMsgIdFn h64 xxhash / 200 bytes 493.00 ns/op 388.00 ns/op 1.27
fastMsgIdFn sha256 / 1000 bytes 12.363 us/op 11.189 us/op 1.10
fastMsgIdFn h32 xxhash / 1000 bytes 490.00 ns/op 400.00 ns/op 1.23
fastMsgIdFn h64 xxhash / 1000 bytes 592.00 ns/op 462.00 ns/op 1.28
fastMsgIdFn sha256 / 10000 bytes 109.91 us/op 100.24 us/op 1.10
fastMsgIdFn h32 xxhash / 10000 bytes 2.0920 us/op 1.8620 us/op 1.12
fastMsgIdFn h64 xxhash / 10000 bytes 1.5460 us/op 1.3220 us/op 1.17
enrSubnets - fastDeserialize 64 bits 1.7000 us/op 1.2330 us/op 1.38
enrSubnets - ssz BitVector 64 bits 636.00 ns/op 477.00 ns/op 1.33
enrSubnets - fastDeserialize 4 bits 211.00 ns/op 173.00 ns/op 1.22
enrSubnets - ssz BitVector 4 bits 631.00 ns/op 487.00 ns/op 1.30
prioritizePeers score -10:0 att 32-0.1 sync 2-0 125.65 us/op 102.63 us/op 1.22
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 165.98 us/op 126.73 us/op 1.31
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 198.47 us/op 163.18 us/op 1.22
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 369.46 us/op 295.12 us/op 1.25
prioritizePeers score 0:0 att 64-1 sync 4-1 446.95 us/op 354.17 us/op 1.26
array of 16000 items push then shift 1.7076 us/op 1.6057 us/op 1.06
LinkedList of 16000 items push then shift 9.1690 ns/op 8.5310 ns/op 1.07
array of 16000 items push then pop 103.23 ns/op 87.281 ns/op 1.18
LinkedList of 16000 items push then pop 8.7820 ns/op 8.3630 ns/op 1.05
array of 24000 items push then shift 2.4135 us/op 2.3341 us/op 1.03
LinkedList of 24000 items push then shift 9.6680 ns/op 8.5550 ns/op 1.13
array of 24000 items push then pop 78.528 ns/op 76.556 ns/op 1.03
LinkedList of 24000 items push then pop 8.6190 ns/op 8.4130 ns/op 1.02
intersect bitArray bitLen 8 13.446 ns/op 13.058 ns/op 1.03
intersect array and set length 8 80.428 ns/op 78.425 ns/op 1.03
intersect bitArray bitLen 128 44.381 ns/op 43.168 ns/op 1.03
intersect array and set length 128 1.1064 us/op 1.0563 us/op 1.05
Buffer.concat 32 items 2.9630 us/op 2.9920 us/op 0.99
Uint8Array.set 32 items 2.2520 us/op 3.0110 us/op 0.75
transfer serialized Status (84 B) 2.0030 us/op 2.1400 us/op 0.94
copy serialized Status (84 B) 1.6680 us/op 1.7940 us/op 0.93
transfer serialized SignedVoluntaryExit (112 B) 2.0680 us/op 2.2680 us/op 0.91
copy serialized SignedVoluntaryExit (112 B) 1.6730 us/op 1.9130 us/op 0.87
transfer serialized ProposerSlashing (416 B) 2.2330 us/op 3.1130 us/op 0.72
copy serialized ProposerSlashing (416 B) 2.0490 us/op 3.1710 us/op 0.65
transfer serialized Attestation (485 B) 2.3170 us/op 3.2320 us/op 0.72
copy serialized Attestation (485 B) 2.1140 us/op 3.1320 us/op 0.67
transfer serialized AttesterSlashing (33232 B) 2.4520 us/op 2.7700 us/op 0.89
copy serialized AttesterSlashing (33232 B) 5.7140 us/op 5.7450 us/op 0.99
transfer serialized Small SignedBeaconBlock (128000 B) 2.7820 us/op 3.0360 us/op 0.92
copy serialized Small SignedBeaconBlock (128000 B) 15.016 us/op 13.129 us/op 1.14
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1260 us/op 3.4430 us/op 0.91
copy serialized Avg SignedBeaconBlock (200000 B) 32.910 us/op 18.851 us/op 1.75
transfer serialized BlobsSidecar (524380 B) 3.1760 us/op 3.5000 us/op 0.91
copy serialized BlobsSidecar (524380 B) 176.37 us/op 162.76 us/op 1.08
transfer serialized Big SignedBeaconBlock (1000000 B) 3.6190 us/op 3.6470 us/op 0.99
copy serialized Big SignedBeaconBlock (1000000 B) 318.16 us/op 283.89 us/op 1.12
pass gossip attestations to forkchoice per slot 2.7006 ms/op 2.5703 ms/op 1.05
forkChoice updateHead vc 100000 bc 64 eq 0 2.1970 ms/op 2.0527 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 0 12.207 ms/op 11.649 ms/op 1.05
forkChoice updateHead vc 1000000 bc 64 eq 0 22.114 ms/op 21.848 ms/op 1.01
forkChoice updateHead vc 600000 bc 320 eq 0 16.983 ms/op 16.205 ms/op 1.05
forkChoice updateHead vc 600000 bc 1200 eq 0 80.958 ms/op 80.704 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 1000 21.577 ms/op 20.807 ms/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 10000 23.870 ms/op 22.623 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 300000 31.290 ms/op 29.918 ms/op 1.05
computeDeltas 4.3618 ms/op 3.5750 ms/op 1.22
computeProposerBoostScoreFromBalances 1.8107 ms/op 1.7658 ms/op 1.03
altair processAttestation - 250000 vs - 7PWei normalcase 2.4871 ms/op 2.1550 ms/op 1.15
altair processAttestation - 250000 vs - 7PWei worstcase 3.6504 ms/op 3.3023 ms/op 1.11
altair processAttestation - setStatus - 1/6 committees join 141.37 us/op 137.37 us/op 1.03
altair processAttestation - setStatus - 1/3 committees join 289.81 us/op 270.54 us/op 1.07
altair processAttestation - setStatus - 1/2 committees join 373.20 us/op 355.55 us/op 1.05
altair processAttestation - setStatus - 2/3 committees join 478.42 us/op 456.66 us/op 1.05
altair processAttestation - setStatus - 4/5 committees join 692.85 us/op 643.25 us/op 1.08
altair processAttestation - setStatus - 100% committees join 769.70 us/op 753.66 us/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase 18.645 ms/op 17.612 ms/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.366 ms/op 25.966 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase 58.892 ms/op 51.975 ms/op 1.13
altair processBlock - 250000 vs - 7PWei worstcase hashState 79.102 ms/op 66.442 ms/op 1.19
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1024 ms/op 2.0262 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei worstcase 29.378 ms/op 29.415 ms/op 1.00
altair processEth1Data - 250000 vs - 7PWei normalcase 493.42 us/op 496.11 us/op 0.99
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.9560 us/op 7.5040 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 24.877 us/op 25.620 us/op 0.97
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 9.8010 us/op 8.4100 us/op 1.17
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.3070 us/op 7.3930 us/op 0.99
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 98.552 us/op 86.378 us/op 1.14
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 776.36 us/op 653.27 us/op 1.19
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.0269 ms/op 930.75 us/op 1.10
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 991.96 us/op 923.19 us/op 1.07
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4170 ms/op 2.3038 ms/op 1.05
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8149 ms/op 1.5044 ms/op 1.21
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9570 ms/op 3.8815 ms/op 1.02
Tree 40 250000 create 308.14 ms/op 318.53 ms/op 0.97
Tree 40 250000 get(125000) 197.81 ns/op 187.28 ns/op 1.06
Tree 40 250000 set(125000) 1.0142 us/op 921.02 ns/op 1.10
Tree 40 250000 toArray() 21.376 ms/op 20.919 ms/op 1.02
Tree 40 250000 iterate all - toArray() + loop 19.934 ms/op 21.425 ms/op 0.93
Tree 40 250000 iterate all - get(i) 72.071 ms/op 70.410 ms/op 1.02
MutableVector 250000 create 13.923 ms/op 11.308 ms/op 1.23
MutableVector 250000 get(125000) 6.3270 ns/op 6.5650 ns/op 0.96
MutableVector 250000 set(125000) 249.18 ns/op 254.86 ns/op 0.98
MutableVector 250000 toArray() 2.7468 ms/op 2.8208 ms/op 0.97
MutableVector 250000 iterate all - toArray() + loop 2.9011 ms/op 3.0747 ms/op 0.94
MutableVector 250000 iterate all - get(i) 1.5302 ms/op 1.5189 ms/op 1.01
Array 250000 create 2.5818 ms/op 2.7529 ms/op 0.94
Array 250000 clone - spread 1.1455 ms/op 1.1392 ms/op 1.01
Array 250000 get(125000) 0.57600 ns/op 0.58900 ns/op 0.98
Array 250000 set(125000) 0.66400 ns/op 0.64900 ns/op 1.02
Array 250000 iterate all - loop 109.17 us/op 90.888 us/op 1.20
effectiveBalanceIncrements clone Uint8Array 300000 33.207 us/op 30.215 us/op 1.10
effectiveBalanceIncrements clone MutableVector 300000 352.00 ns/op 361.00 ns/op 0.98
effectiveBalanceIncrements rw all Uint8Array 300000 171.20 us/op 165.60 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 85.492 ms/op 80.488 ms/op 1.06
phase0 afterProcessEpoch - 250000 vs - 7PWei 118.38 ms/op 112.82 ms/op 1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei 45.742 ms/op 33.118 ms/op 1.38
altair processEpoch - mainnet_e81889 374.58 ms/op 329.09 ms/op 1.14
mainnet_e81889 - altair beforeProcessEpoch 74.758 ms/op 68.834 ms/op 1.09
mainnet_e81889 - altair processJustificationAndFinalization 34.263 us/op 17.402 us/op 1.97
mainnet_e81889 - altair processInactivityUpdates 6.7997 ms/op 5.5843 ms/op 1.22
mainnet_e81889 - altair processRewardsAndPenalties 60.570 ms/op 67.108 ms/op 0.90
mainnet_e81889 - altair processRegistryUpdates 3.8370 us/op 2.9530 us/op 1.30
mainnet_e81889 - altair processSlashings 1.0320 us/op 430.00 ns/op 2.40
mainnet_e81889 - altair processEth1DataReset 1.1000 us/op 503.00 ns/op 2.19
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.8988 ms/op 1.2874 ms/op 1.47
mainnet_e81889 - altair processSlashingsReset 9.7060 us/op 8.0360 us/op 1.21
mainnet_e81889 - altair processRandaoMixesReset 10.658 us/op 5.8920 us/op 1.81
mainnet_e81889 - altair processHistoricalRootsUpdate 1.8220 us/op 1.2550 us/op 1.45
mainnet_e81889 - altair processParticipationFlagUpdates 6.9020 us/op 2.2420 us/op 3.08
mainnet_e81889 - altair processSyncCommitteeUpdates 1.3520 us/op 518.00 ns/op 2.61
mainnet_e81889 - altair afterProcessEpoch 139.26 ms/op 128.29 ms/op 1.09
phase0 processEpoch - mainnet_e58758 410.05 ms/op 375.59 ms/op 1.09
mainnet_e58758 - phase0 beforeProcessEpoch 153.19 ms/op 140.87 ms/op 1.09
mainnet_e58758 - phase0 processJustificationAndFinalization 27.864 us/op 17.053 us/op 1.63
mainnet_e58758 - phase0 processRewardsAndPenalties 72.676 ms/op 64.596 ms/op 1.13
mainnet_e58758 - phase0 processRegistryUpdates 15.949 us/op 8.5610 us/op 1.86
mainnet_e58758 - phase0 processSlashings 1.3470 us/op 632.00 ns/op 2.13
mainnet_e58758 - phase0 processEth1DataReset 1.1990 us/op 522.00 ns/op 2.30
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.5843 ms/op 1.0091 ms/op 1.57
mainnet_e58758 - phase0 processSlashingsReset 7.3770 us/op 3.3840 us/op 2.18
mainnet_e58758 - phase0 processRandaoMixesReset 10.788 us/op 5.3160 us/op 2.03
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.0250 us/op 663.00 ns/op 3.05
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.4130 us/op 3.8230 us/op 1.94
mainnet_e58758 - phase0 afterProcessEpoch 111.78 ms/op 99.013 ms/op 1.13
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.6703 ms/op 1.2736 ms/op 1.31
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4723 ms/op 1.6261 ms/op 1.52
altair processInactivityUpdates - 250000 normalcase 31.293 ms/op 26.380 ms/op 1.19
altair processInactivityUpdates - 250000 worstcase 28.547 ms/op 26.953 ms/op 1.06
phase0 processRegistryUpdates - 250000 normalcase 12.755 us/op 7.1730 us/op 1.78
phase0 processRegistryUpdates - 250000 badcase_full_deposits 352.34 us/op 263.02 us/op 1.34
phase0 processRegistryUpdates - 250000 worstcase 0.5 144.86 ms/op 125.00 ms/op 1.16
altair processRewardsAndPenalties - 250000 normalcase 78.009 ms/op 70.229 ms/op 1.11
altair processRewardsAndPenalties - 250000 worstcase 86.681 ms/op 70.439 ms/op 1.23
phase0 getAttestationDeltas - 250000 normalcase 10.189 ms/op 7.1056 ms/op 1.43
phase0 getAttestationDeltas - 250000 worstcase 10.319 ms/op 6.9159 ms/op 1.49
phase0 processSlashings - 250000 worstcase 5.0563 ms/op 3.8268 ms/op 1.32
altair processSyncCommitteeUpdates - 250000 211.73 ms/op 183.28 ms/op 1.16
BeaconState.hashTreeRoot - No change 324.00 ns/op 289.00 ns/op 1.12
BeaconState.hashTreeRoot - 1 full validator 61.857 us/op 56.300 us/op 1.10
BeaconState.hashTreeRoot - 32 full validator 644.45 us/op 548.96 us/op 1.17
BeaconState.hashTreeRoot - 512 full validator 7.1589 ms/op 5.0869 ms/op 1.41
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 73.446 us/op 66.001 us/op 1.11
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0891 ms/op 908.99 us/op 1.20
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 14.204 ms/op 13.697 ms/op 1.04
BeaconState.hashTreeRoot - 1 balances 52.646 us/op 51.621 us/op 1.02
BeaconState.hashTreeRoot - 32 balances 555.54 us/op 467.01 us/op 1.19
BeaconState.hashTreeRoot - 512 balances 5.3059 ms/op 4.2735 ms/op 1.24
BeaconState.hashTreeRoot - 250000 balances 82.590 ms/op 75.699 ms/op 1.09
aggregationBits - 2048 els - zipIndexesInBitList 24.064 us/op 17.299 us/op 1.39
regular array get 100000 times 54.691 us/op 34.950 us/op 1.56
wrappedArray get 100000 times 52.637 us/op 34.534 us/op 1.52
arrayWithProxy get 100000 times 18.990 ms/op 18.448 ms/op 1.03
ssz.Root.equals 771.00 ns/op 596.00 ns/op 1.29
byteArrayEquals 738.00 ns/op 582.00 ns/op 1.27
shuffle list - 16384 els 8.1746 ms/op 6.9836 ms/op 1.17
shuffle list - 250000 els 126.42 ms/op 101.44 ms/op 1.25
processSlot - 1 slots 10.954 us/op 8.9040 us/op 1.23
processSlot - 32 slots 1.8011 ms/op 1.4114 ms/op 1.28
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 45.843 ms/op 36.762 ms/op 1.25
getCommitteeAssignments - req 1 vs - 250000 vc 4.0005 ms/op 2.9254 ms/op 1.37
getCommitteeAssignments - req 100 vs - 250000 vc 5.2832 ms/op 4.1639 ms/op 1.27
getCommitteeAssignments - req 1000 vs - 250000 vc 6.6794 ms/op 4.5336 ms/op 1.47
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.6100 ns/op 4.8800 ns/op 1.35
state getBlockRootAtSlot - 250000 vs - 7PWei 850.84 ns/op 912.29 ns/op 0.93
computeProposers - vc 250000 14.342 ms/op 11.606 ms/op 1.24
computeEpochShuffling - vc 250000 134.49 ms/op 106.09 ms/op 1.27
getNextSyncCommittee - vc 250000 244.73 ms/op 184.70 ms/op 1.32
computeSigningRoot for AttestationData 18.667 us/op 14.344 us/op 1.30
hash AttestationData serialized data then Buffer.toString(base64) 2.9971 us/op 2.5482 us/op 1.18
toHexString serialized data 2.0214 us/op 1.2228 us/op 1.65
Buffer.toString(base64) 451.06 ns/op 348.13 ns/op 1.30

by benchmarkbot/action

@matthewkeil matthewkeil changed the title feat(scripts): add clean:nm to root package.json chore(scripts): add clean:nm to root package.json Jun 6, 2023
@matthewkeil matthewkeil merged commit c775ad7 into unstable Jun 6, 2023
@matthewkeil matthewkeil deleted the mkeil/clean-nm-script branch June 6, 2023 15:21
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewkeil @wemeetagain @nflaig