fix: update getConnectionsMap and getConnection functions
#5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
changed the title
getConnectionsMap and getConnection functions
wemeetagain
requested changes
Feb 3, 2023
There was a problem hiding this comment.
I would prefer to not have additional runtime logic here for the benefit of making the types prettier.
Also we've had trouble in the past with string->peerId conversions causing poor performance:
libp2p/js-libp2p#680 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following the discussion libp2p/js-libp2p#1567 (comment) this will reduce some of the complexities of utility functions.
Description
This along with a solution for libp2p/js-libp2p#1574 will help us to better inspect, debug and observe the libp2p object overall