Modular Reqresp Package #4775
Merged
Modular Reqresp Package #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Nov 17, 2022
packages/reqresp/.babel-register
Outdated
| @@ -0,0 +1,15 @@ | |||
| /* | |||
wemeetagain
reviewed
Nov 17, 2022
dapplion
reviewed
Nov 17, 2022
packages/reqresp/src/types.ts
Outdated
| LightClientBootstrap = "light_client_bootstrap", | ||
| LightClientUpdatesByRange = "light_client_updates_by_range", | ||
| LightClientFinalityUpdate = "light_client_finality_update", | ||
| LightClientOptimisticUpdate = "light_client_optimistic_update", |
There was a problem hiding this comment.
The reqResp package is agnostic of full node specifics. All of this should be in the beacon-node package only
dapplion
force-pushed
the
dapplion/reqresp-modular
branch
from
8cca03b to
38b9225
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Nov 19, 2022
| @@ -1,10 +0,0 @@ | |||
| import {expect} from "chai"; | |||
There was a problem hiding this comment.
All the unit tests are deleted?
There was a problem hiding this comment.
That we discussed to add and fix the unit tests in a separate PR to not block this one.
dapplion
approved these changes
Nov 20, 2022
| /** | ||
| * https://github.com/ethereum/consensus-specs/blob/v1.2.0/specs/phase0/p2p-interface.md#protocol-identification | ||
| */ | ||
| export function parseProtocolID(protocolId: string): Protocol { |
There was a problem hiding this comment.
This function was not in source because it's only used in tests. I try to not keep any code in source that's only for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the
reqrespmodular so it can be consumed among light-client and beacon-node easily.Description
Extract the reqresp out of beacon node and create its own package. Made the messages and handlers generic.
Steps to test or reproduce
Run unit tests.