Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sim-merge: activate geth, commit ids as workflow env vars, simple txs scenario, dockerized geth based config for tests #3460

Merged
merged 3 commits into from
Dec 6, 2021
Merged

sim-merge: activate geth, commit ids as workflow env vars, simple txs scenario, dockerized geth based config for tests #3460

merged 3 commits into from
Dec 6, 2021

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Nov 24, 2021 •
edited by dapplion
Loading

Motivation

  • Geth was disabled since its interop branch started failing, now it has been fixed so activating geth for interop.
  • Fixing the commit vars as global env variables in the sim merge workflow for readability and easy update
  • A transaction scenario for a simple eth transfer between two accounts
  • Config for dockerized geth based setup to run and test the scripts on local

Description

Closes #3444
partially resolves #3425 (transaction tests addition in interop file)

@codeclimate
Copy link

codeclimate bot commented Nov 24, 2021 •
edited
Loading

Code Climate has analyzed commit b5e38e2 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 24, 2021 •
edited
Loading

Codecov Report

Merging #3460 (b5e38e2) into master (cd24a96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3460   +/-   ##
=======================================
  Coverage   38.09%   38.09%           
=======================================
  Files         303      303           
  Lines        7944     7944           
  Branches     1224     1224           
=======================================
  Hits         3026     3026           
  Misses       4777     4777           
  Partials      141      141

@g11tech g11tech mentioned this pull request Nov 25, 2021
Closed
3 tasks
@g11tech g11tech changed the title activate geth and EL interop sim commits as workflow env vars sim-merge: activate geth, commit ids as workflow env vars, simple txs scenario, dockerized geth based config for tests Nov 25, 2021
dapplion
dapplion approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I can help do smart contract txs after CSCON next week

wemeetagain
wemeetagain approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dapplion add txs in a fresh PR?

@dapplion dapplion merged commit 1bf5457 into ChainSafe:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

@ColinSchwarz ColinSchwarz Awaiting requested review from ColinSchwarz

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone specific commit for EL interop tests Kintsugi backlog
3 participants
@g11tech @wemeetagain @dapplion