Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement handling of EphemeralAddresses #31

Open
wants to merge 12 commits into
base: ec2/memwallet
Choose a base branch
from
Open

Implement handling of EphemeralAddresses #31

wants to merge 12 commits into from

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Oct 8, 2024

No description provided.

@ec2 ec2 changed the base branch from ec2/memwallet to ec2/bug-fix October 8, 2024 01:12
willemolding
willemolding reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@willemolding willemolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm feeling too dumb to be able to review this right now :( We might have to have a call so I can get up to speed on how some parts work

zcash_client_memory/src/error.rs Show resolved Hide resolved
Base automatically changed from ec2/bug-fix to ec2/memwallet October 10, 2024 15:57
@willemolding
Copy link
Collaborator

Made some changes so that it will build properly with different feature flag configurations

@willemolding willemolding self-requested a review October 11, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemolding willemolding willemolding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ec2 @willemolding