fix: throw on stream reset #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Apr 19, 2023
|
I have reverted this to a draft PR as this not currently passing my interop test with js-libp2p more details: https://filecoinproject.slack.com/archives/C03K82MU486/p1681942784164429 |
maschad
force-pushed
the
fix/update-resetController
branch
from
265df2c to
887b24d
Compare
maschad
force-pushed
the
fix/update-resetController
branch
from
d939e6e to
5a46abe
Compare
wemeetagain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2023
## [4.0.1](v4.0.0...v4.0.1) (2023-05-01) ### Bug Fixes * updated reset for abort controller ([#26](#26)) ([6fc5ebd](6fc5ebd))
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conversation here it seems that certain errors where not being propagated as an
ERR_STREAM_RESET