Fix lint errors and tests #67
Conversation
|
Seems like bcrypto library relies on Buffer polyfill in browser, any idea how to fix that @hugomrdias |
You need to run aegir cmds with --node true, we removed the dependency on node globals and builtins in all the other ipfs/libp2p repos and deps ipfs/js-ipfs#2924 . This was because the next version of webpack (v5) is going to remove automatic injection of node stuff. |
| @@ -27,6 +30,7 @@ | |||
| "@types/mocha": "^5.2.7", | |||
| "aegir": "ipfs/aegir#feat/cosmiconfig", | |||
| "chai": "^4.2.0", | |||
| "karma-mocha-webworker": "^1.3.0", | |||
There was a problem hiding this comment.
You should not need this, karma has a weird issue with this module and fails to load it if the package doesnt come from npm. So when we release aegir properly this can be removed.
There was a problem hiding this comment.
oh, did not know that, failed locally so ive added it. Will remove once we update aegir version
There was a problem hiding this comment.
Even with released aegir it still says that it's missing
|
aegir 25.0.0 released https://github.com/ipfs/aegir/blob/master/CHANGELOG.md#2500-2020-06-20 |
TODO: