Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bcypto #100

Merged
merged 15 commits into from
Jun 11, 2021
Merged

Remove bcypto #100

merged 15 commits into from
Jun 11, 2021

Conversation

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #100 (1e6dc90) into master (168ae90) will increase coverage by 0.03%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   89.09%   89.13%   +0.03%     
==========================================
  Files          16       16              
  Lines        1807     1832      +25     
  Branches      239      243       +4     
==========================================
+ Hits         1610     1633      +23     
- Misses        197      199       +2     
Impacted Files Coverage Δ
src/utils.ts 98.41% <89.47%> (-1.59%) ⬇️
src/handshakes/abstract-handshake.ts 94.14% <100.00%> (+0.29%) ⬆️
src/noise.ts 77.34% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168ae90...1e6dc90. Read the comment docs.

package.json Outdated Show resolved Hide resolved
src/handshakes/abstract-handshake.ts Outdated Show resolved Hide resolved
src/noise.ts Show resolved Hide resolved
@vasco-santos vasco-santos self-requested a review May 31, 2021 10:30
@mpetrunic mpetrunic merged commit 5e3af2a into ChainSafe:master Jun 11, 2021
@mpetrunic mpetrunic deleted the mpetrun5/remove-bcypto branch June 11, 2021 08:39
@vasco-santos
Copy link
Collaborator

🎉

Do you have any metrics on the bundle size difference?

@vasco-santos
Copy link
Collaborator

~27% decrease on its bundle size, from 191.5kb to 141.2kb (minified+gzipped)

🚀 ❤️

@mpetrunic
Copy link
Member

mpetrunic commented Jun 11, 2021

~27% decrease on its bundle size, from 191.5kb to 141.2kb (minified+gzipped)

🚀 ❤️

from our benchmark there is also speed improvement:

NEW:

Initializing handshake benchmark
Init complete, running benchmark
handshake x 39.97 ops/sec ±4.98% (67 runs sampled)
Done in 6.04s.


OLD:

Initializing handshake benchmark
Init complete, running benchmark
handshake x 27.23 ops/sec ±4.57% (67 runs sampled)
Done in 6.10s.

achingbrain pushed a commit to ipfs/js-ipfs that referenced this pull request Jun 15, 2021
With ChainSafe/js-libp2p-noise#100 in, we can now have a smaller bundle size. Also fixes node build

`libp2p-noise`: ~27% decrease on its bundle size, from 191.5kb to 141.2kb (minified+gzipped)
`ipfs`: ~10% decrease on its bundle size.

Closes #3704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bcrypto dep
4 participants