-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bcypto #100
Remove bcypto #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 89.09% 89.13% +0.03%
==========================================
Files 16 16
Lines 1807 1832 +25
Branches 239 243 +4
==========================================
+ Hits 1610 1633 +23
- Misses 197 199 +2
Continue to review full report at Codecov.
|
🎉 Do you have any metrics on the bundle size difference? |
~27% decrease on its bundle size, from 191.5kb to 141.2kb (minified+gzipped) 🚀 ❤️ |
from our benchmark there is also speed improvement:
|
With ChainSafe/js-libp2p-noise#100 in, we can now have a smaller bundle size. Also fixes node build `libp2p-noise`: ~27% decrease on its bundle size, from 191.5kb to 141.2kb (minified+gzipped) `ipfs`: ~10% decrease on its bundle size. Closes #3704
Replaced:
resolves #93