feat: add ethereum/beacon-metrics per spec #508
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
commented
Sep 24, 2024
| @@ -2294,7 +2295,7 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub | |||
| topic, | |||
| tosendCount, | |||
| tosend.size, | |||
| rawMsg.data != null ? rawMsg.data.length : 0, | |||
| RPC.Message.getSize(rawMsg), | |||
There was a problem hiding this comment.
I noticed this, we were only counting the "data" portion but more than that gets sent over the wire in a RPC.message. I updated with this method but not sure if that is "correct" because I did not find anything in the spec speaking to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More metrics were added to
ethereum/beacon-metricsto help track peerDAS. There were also a couple of adds related to gossipsub so made those changes here.NOTE: There is a breaking change to the metrics. It is not an API break but the metric names changes such that dashboards will not show up correctly without changing the PromQL
A few of the metric name changed so a PR to lodestar will need to be made when updating the dependency to modify the dashboards so they reference the updated metric names