chore: track total metric for mesh inclusion/churn events #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
86 tasks
wemeetagain
reviewed
Oct 9, 2024
| @@ -213,6 +213,11 @@ export function getMetrics( | |||
| help: 'Number of times we include peers in a topic mesh for random reasons', | |||
| labelNames: ['topic'] | |||
| }), | |||
| meshPeerInclusionEventsTotal: register.gauge<{ topic: TopicLabel }>({ | |||
There was a problem hiding this comment.
maybe we can rename these metrics. I think "inclusion/churn" is a bit more confusing than "add/remove"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We removed
gossipsub_mesh_peer_inclusion_events_totalandgossipsub_peer_churn_events_totalin #460 but lodestar still needs it, see ChainSafe/lodestar#5919Description
Add back these metrics