Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sendRpc in a for loop #347

Merged
merged 3 commits into from
Oct 3, 2022
Merged

fix: sendRpc in a for loop #347

merged 3 commits into from
Oct 3, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Sep 28, 2022

Description

  • The sendRpc() function expect new rpc param every time we call it because it modifies that param. If we call it in a for loop, the control part could be accumulated from prior loops.
  • The issue may happen in forward and publish scenario

@twoeths twoeths requested a review from a team as a code owner September 28, 2022 08:50
@mpetrunic
Copy link
Member

"feat: fix"? 😂

@twoeths twoeths changed the title feat: fix sendRpc in a for loop fix: sendRpc in a for loop Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 79.98% // Head: 79.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5afb3ca) compared to base (4c73e81).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5afb3ca differs from pull request most recent head 2845ebc. Consider uploading reports for the commit 2845ebc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   79.98%   79.97%   -0.01%     
==========================================
  Files          44       44              
  Lines       11226    11223       -3     
  Branches     1018     1018              
==========================================
- Hits         8979     8976       -3     
  Misses       2247     2247              
Impacted Files Coverage Δ
src/index.ts 70.22% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dapplion
dapplion previously approved these changes Oct 3, 2022
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed createGossipRpc function completely

@dapplion dapplion merged commit 74cb495 into master Oct 3, 2022
@dapplion dapplion deleted the tuyen/sendRpc-no-share-param branch October 3, 2022 12:57
dapplion added a commit that referenced this pull request Oct 3, 2022
dapplion added a commit that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants