fix: use typed event emitter class #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
commented
Oct 31, 2023
| detail: { peerId: from, subscriptions } | ||
| }) | ||
| ) | ||
| this.safeDispatchEvent<SubscriptionChangeData>('subscription-change', { |
There was a problem hiding this comment.
This style of invocation type-checks the detail field.
achingbrain
changed the title
|
Looks like the custom linting rules in this repo are broken. Upgrading @typescript-eslint/parser may help - or since aegir is being used to build this project, perhaps delete all the custom eslint stuff and just use aegir's linting? |
3 tasks
The typed `EventEmitter` class from `@libp2p/interface/events` has been renamed `TypedEventEmitter` along with a `TypedEventTarget` interface. The old name is still exported so it's a backwards compatible change but it will be removed in a future version of `@libp2p/interface` so this change future-proofs `@chainsafe/libp2p-gossipsub` against that upcoming release.
achingbrain
force-pushed
the
fix/use-typed-event-emitters
branch
from
fef6d0a
to
7e2fbe0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 81.35% 81.35% -0.01%
==========================================
Files 48 48
Lines 12267 12265 -2
Branches 1291 1291
==========================================
- Hits 9980 9978 -2
Misses 2287 2287 ☔ View full report in Codecov by Sentry. |
wemeetagain
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typed
EventEmitterclass from@libp2p/interface/eventshas been renamedTypedEventEmitteralong with aTypedEventTargetinterface.The old name is still exported so it's a backwards compatible change but it will be removed in a future version of
@libp2p/interfaceso this change future-proofs@chainsafe/libp2p-gossipsubagainst that upcoming release.