-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dot/rpc: implement RPC call state_control #896
Conversation
…56-rpc-block_production
…ssamer into ed/856-rpc-block_production
@edwardmack I updated this to have a RPC dev module that directly uses the BlockProducer interface. it looks like it works now:
then:
I'm wondering whether we should have separate calls for BABE and network (and start and stop), what do you think? it works as is so not a huge deal. |
@noot, this looks great, it makes sense to use the BlockProducer interface. Regarding call format, I'm open. I could create a call to start and one to stop, and pass in babe or network (and possible future things). OR I could do a call for babe and on for network, and pass in start or stop. I'm open, let me know. |
@edwardmack let's leave it for now, in the future if we add more services to control it might make more sense to break it out. but I think it's fine as is |
Changes
Introduce RPC method to control services
state_control
and params array of strings where first element is service (currentlybabe
ornetwork
), second element command (start
orstop
).Tests:
Start gossamer with rpc
Make RPC call (example to stop babe service):
Checklist:
Issues: