dot/rpc, dot/network: Implement RPC system_nodeRoles #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
reviewed
May 21, 2020
| @@ -410,3 +410,8 @@ func (s *Service) Peers() []common.PeerInfo { | |||
| } | |||
| return peers | |||
| } | |||
|
|
|||
| // NodeRoles Returns the roles the node is running as. | |||
There was a problem hiding this comment.
I think this should be part of the core service rather than the network service? maybe? we pass this configuration value down from the dot configuration to the core and network services and the network service is less the source of truth for this sort of thing than core but probably ok as is - kinda just thinking this out loud.
There was a problem hiding this comment.
I'd like to leave this as is for now. I agree it makes sense to include this in core, however the RPC module that's using this doesn't have reference to coreAPI, it currently has access to networkAPI and systemAPI.
thomasmodeneis
approved these changes
May 22, 2020
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* implement system_nodeRoles RPC * add tests * update rpc service_test.go * update error checking
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Checklist:
Issues: