Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #591

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Update CONTRIBUTING.md #591

merged 5 commits into from
Feb 10, 2020

Conversation

amerameen
Copy link
Contributor

Updated to the best of my knowledge. Please let me know if anything is still out of date.

Issues: Closes #453

Updated to the best of my knowledge. Please let me know if anything is still out of date.

Closes #453 453
@claassistantio
Copy link

claassistantio commented Feb 4, 2020

CLA assistant check
All committers have signed the CLA.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from few typos!

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me.

Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, useful additions and links.

@noot noot merged commit 1f0208c into development Feb 10, 2020
@noot noot deleted the amer/update-contributing.md branch February 10, 2020 16:38
ryanchristo pushed a commit that referenced this pull request Jun 24, 2020
* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md
6 participants