Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/runtime): Fix wasm error: out of bounds memory access at #9412261 #3588

Merged
merged 16 commits into from
Dec 7, 2023
Merged

fix(lib/runtime): Fix wasm error: out of bounds memory access at #9412261 #3588

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2aeffc7
chore: make wasm max pages default mem size
EclesioMeloJunior Nov 15, 2023
2d8f49f
chore: use latest version of wazero fork
EclesioMeloJunior Nov 15, 2023
8f5b32c
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 17, 2023
f931a9f
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 20, 2023
c84eca7
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 21, 2023
22bbc5a
Merge branch 'wasm-error' of github.com:ChainSafe/gossamer into wasm-…
EclesioMeloJunior Nov 21, 2023
daaae88
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 21, 2023
8305183
chore: increase runner spec
EclesioMeloJunior Nov 21, 2023
48fe8a1
Merge branch 'wasm-error' of github.com:ChainSafe/gossamer into wasm-…
EclesioMeloJunior Nov 21, 2023
feabd35
chore: make `MinPages` configurable
EclesioMeloJunior Nov 21, 2023
321bdb3
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 21, 2023
ea9aa2a
Merge branch 'development' into wasm-error
EclesioMeloJunior Nov 22, 2023
75e6ad6
Merge branch 'development' into wasm-error
EclesioMeloJunior Dec 6, 2023
dbfbd63
Merge branch 'development' into wasm-error
EclesioMeloJunior Dec 6, 2023
ddc7b41
chore: remove configurable mem size
EclesioMeloJunior Dec 6, 2023
e7d986c
chore: revert unneeded changes
EclesioMeloJunior Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,6 @@ require (

go 1.21

replace github.com/tetratelabs/wazero => github.com/ChainSafe/wazero v0.0.0-20230710171859-39a4c235ec1f
replace github.com/tetratelabs/wazero => github.com/ChainSafe/wazero v0.0.0-20231114190045-1d874d099362

replace github.com/centrifuge/go-substrate-rpc-client/v4 => github.com/timwu20/go-substrate-rpc-client/v4 v4.0.0-20231110032757-3d8e441b7303
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
github.com/ChainSafe/go-schnorrkel v1.1.0 h1:rZ6EU+CZFCjB4sHUE1jIu8VDoB/wRKZxoe1tkcO71Wk=
github.com/ChainSafe/go-schnorrkel v1.1.0/go.mod h1:ABkENxiP+cvjFiByMIZ9LYbRoNNLeBLiakC1XeTFxfE=
github.com/ChainSafe/wazero v0.0.0-20230710171859-39a4c235ec1f h1:/sI8TMJ77HL2UImQs7pY7khVN96EXQJGVOrX88dTpcY=
github.com/ChainSafe/wazero v0.0.0-20230710171859-39a4c235ec1f/go.mod h1:wYx2gNRg8/WihJfSDxA1TIL8H+GkfLYm+bIfbblu9VQ=
github.com/ChainSafe/wazero v0.0.0-20231114190045-1d874d099362 h1:hbvvSSB436JJalwq/2fRZwJpptvq9HMOLYVZX9oVHKM=
github.com/ChainSafe/wazero v0.0.0-20231114190045-1d874d099362/go.mod h1:0U0G41+ochRKoPKCJlh0jMg1CHkyfK8kDqiirMmKY8A=
github.com/CloudyKit/fastprinter v0.0.0-20200109182630-33d98a066a53/go.mod h1:+3IMCy2vIlbG1XG/0ggNQv0SvxCAIpPM5b1nCz56Xno=
github.com/CloudyKit/jet/v3 v3.0.0/go.mod h1:HKQPgSJmdK8hdoAbKUUWajkHyHo4RaU5rMdUywE7VMo=
github.com/DataDog/zstd v1.4.1/go.mod h1:1jcaCB/ufaK+sKp1NBhlGmpz41jOoPQ35bpF36t7BBo=
Expand Down
2 changes: 1 addition & 1 deletion lib/runtime/wazero/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func NewInstance(code []byte, cfg Config) (instance *Instance, err error) {

_, err = rt.NewHostModuleBuilder("env").
// values from newer kusama/polkadot runtimes
ExportMemory("memory", 23).
ExportMemory("memory", allocator.MaxWasmPages-1).
EclesioMeloJunior marked this conversation as resolved.
Show resolved Hide resolved
NewFunctionBuilder().
WithFunc(ext_logging_log_version_1).
Export("ext_logging_log_version_1").
Expand Down
Loading