Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(state): remove Full online pruner #3063

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jan 24, 2023

Changes

Remove the (buggy, incomplete, unused) full online pruner, in order to unblock #3005

Tests

Issues

Related to #1973 and #2835

Primary Reviewer

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #3063 (b5b1fd9) into development (2b5bc2b) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3063      +/-   ##
===============================================
- Coverage        51.58%   51.56%   -0.02%     
===============================================
  Files              219      219              
  Lines            27997    27984      -13     
===============================================
- Hits             14442    14430      -12     
+ Misses           12271    12270       -1     
  Partials          1284     1284              

@jimjbrettj
Copy link
Contributor

Do we have plans to store the current pruner in a different branch or something before deletion? That way we can reference in the future

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left a comment

@qdm12
Copy link
Contributor Author

qdm12 commented Jan 25, 2023

Do we have plans to store the current pruner in a different branch or something before deletion? That way we can reference in the future

The new pruner is being worked on at #2831 (blocked by #3050) which I'll rebase once this gets merged, and will probably finish it sometime in February during my "off time" 😸 We don't really need the older online pruner code since it's really buggy/flawed, and the new one is already separate/quite different (still flawed regarding fork-awareness as you pointed out 👍)

cmd/gossamer/flags.go Outdated Show resolved Hide resolved
dot/state/service_integration_test.go Show resolved Hide resolved
@qdm12 qdm12 force-pushed the qdm12/state/remove-full-pruner branch from d157ca5 to b5b1fd9 Compare January 26, 2023 13:31
@qdm12 qdm12 merged commit ef40637 into development Jan 26, 2023
@qdm12 qdm12 deleted the qdm12/state/remove-full-pruner branch January 26, 2023 14:10
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants