-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(state): remove Full online pruner #3063
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3063 +/- ##
===============================================
- Coverage 51.58% 51.56% -0.02%
===============================================
Files 219 219
Lines 27997 27984 -13
===============================================
- Hits 14442 14430 -12
+ Misses 12271 12270 -1
Partials 1284 1284 |
Do we have plans to store the current pruner in a different branch or something before deletion? That way we can reference in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a comment
The new pruner is being worked on at #2831 (blocked by #3050) which I'll rebase once this gets merged, and will probably finish it sometime in February during my "off time" 😸 We don't really need the older online pruner code since it's really buggy/flawed, and the new one is already separate/quite different (still flawed regarding fork-awareness as you pointed out 👍) |
d157ca5
to
b5b1fd9
Compare
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Remove the (buggy, incomplete, unused) full online pruner, in order to unblock #3005
Tests
Issues
Related to #1973 and #2835
Primary Reviewer