Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix all Deepsource issues #3046

Merged
merged 3 commits into from
Jan 24, 2023
Merged

fix(ci): fix all Deepsource issues #3046

merged 3 commits into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. Fix Usage of both value and pointer receivers

    @qdm12
    qdm12 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1d4d141 View commit details
    Browse the repository at this point in the history

  2. Fix Empty slice literal used to declare a variable

    @qdm12
    qdm12 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    758ea3f View commit details
    Browse the repository at this point in the history

  3. Use pointer receivers for some types: 

    - Trie `Node`'s `Copy` method
- pprof `Settings`'s `String` method
Keep value receivers for some types:
- Keep value receivers for VDTs
- `common.Hash`, `transaction.priorityQueue`
    @qdm12
    qdm12 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6e26064 View commit details
    Browse the repository at this point in the history