chore(tests/stress): refactor compareBlocksByNumber
#2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
noot
approved these changes
Mar 14, 2022
timwu20
reviewed
Mar 15, 2022
| wg.Add(len(nodes)) | ||
| func compareBlocksByNumber(ctx context.Context, t *testing.T, nodes []*utils.Node, | ||
| num string) (hashToKeys map[common.Hash][]string) { | ||
| type resultContainer struct { |
There was a problem hiding this comment.
nit:
Suggested change
| type resultContainer struct { | |
| type result struct { |
There was a problem hiding this comment.
If I rename to result govet complains about shadowing with the result-named variable below.
And I know I could rename that variable below from result to r, but that defeats my crusade against single letter variable names ⚔️ (except i for indexes). If you have a better name, feel free to say it 😄
Also that's an inlined type so it won't pollute the API so it's not a big deal either.
Comment on lines
+121
to
+122
| const comparisonTimeout = 5 * time.Second | ||
| compareCtx, cancel := context.WithTimeout(ctx, comparisonTimeout) |
There was a problem hiding this comment.
Suggested change
| const comparisonTimeout = 5 * time.Second | |
| compareCtx, cancel := context.WithTimeout(ctx, comparisonTimeout) | |
| const comparisonTimeout = 5 * time.Second | |
| compareCtx, cancel := context.WithTimeout(ctx, 5 * time.Second) |
why not inline?
There was a problem hiding this comment.
Because I got tortured by gomnd for years... So now I constant most of my various 'constant' numbers.
- Takes in context - Retry as long as context is not canceled - Assert errors and common values
qdm12
force-pushed
the
qdm12/tests-refactor-1
branch
from
4a59c01
to
209ac73
Compare
Codecov Report
@@ Coverage Diff @@
## development #2370 +/- ##
===============================================
- Coverage 58.06% 58.01% -0.05%
===============================================
Files 214 214
Lines 28007 28007
===============================================
- Hits 16261 16247 -14
- Misses 10111 10121 +10
- Partials 1635 1639 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rrtti
pushed a commit
to polkadot-fellows/seeding
that referenced
this pull request
Sep 29, 2022
I am Quentin Mc Gaw, a software engineer working the Go Polkadot host **Gossamer**. I have been working full time on Gossamer since October 2021, mostly on the state trie and storage. I have also made a [few minor pull requests](https://github.com/w3f/polkadot-spec/pulls?q=is%3Apr+is%3Aclosed+author%3Aqdm12) to the Polkadot specification repository. I am requesting to join the Fellowship at rank 1. ## Main contributions ### Gossamer - Fix memory leaks - Trie encoding buffer pools usage fixed [#2009](ChainSafe/gossamer#2009) - Fix state map of tries memory leak [#2286](ChainSafe/gossamer#2286) - Fix sync benchmark [#2234](ChainSafe/gossamer#2234) - Trie proof fixes ([#2604](ChainSafe/gossamer#2604), [#2661](ChainSafe/gossamer#2661)) - Fix end to end tests orchestration ([#2470](ChainSafe/gossamer#2470), [#2452](ChainSafe/gossamer#2452), [#2385](ChainSafe/gossamer#2385), [#2370](ChainSafe/gossamer#2370)) - State trie statistics ([#2378](ChainSafe/gossamer#2378), [#2310](ChainSafe/gossamer#2310), [#2272](ChainSafe/gossamer#2272)) - State trie fixes and improvements - Only deep copy nodes when mutation is certain [#2352](ChainSafe/gossamer#2352) and [#2223](ChainSafe/gossamer#2223) - Only deep copy necessary fields of a node [#2384](ChainSafe/gossamer#2384) - Use Merkle values for database keys instead of always hash [#2725](ChainSafe/gossamer#2725) - Opportunistic parallel Merkle value commputing [#2081](ChainSafe/gossamer#2081) - Grandpa capped number of tracked messages ([#2490](ChainSafe/gossamer#2490), [#2485](ChainSafe/gossamer#2485)) - Add pprof HTTP service for profiling [#1991](ChainSafe/gossamer#1991) Ongoing work: - State trie lazy loading and caching - State trie v1 support ([#2736](ChainSafe/gossamer#2736), [#2747](ChainSafe/gossamer#2747), [#2687](ChainSafe/gossamer#2687), [#2686](ChainSafe/gossamer#2686), [#2685](ChainSafe/gossamer#2685), [#2673](ChainSafe/gossamer#2673), [#2611](ChainSafe/gossamer#2611), [#2530](ChainSafe/gossamer#2530)) ### Polkadot specification ➡️ [Pull requests from qdm12](https://github.com/w3f/polkadot-spec/pulls?q=is%3Apr+is%3Aclosed+author%3Aqdm12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
First in a serie of
tests/refactor PRsThe end goal is to move timeouts responsibility to the test instead of hidden in helpers.
Tests
Issues
Primary Reviewer