Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): move packages to internal directory #2139

Closed
wants to merge 4 commits into from

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jan 4, 2022

Changes

πŸ’β€β™‚οΈ This PR is designed to be nice with other PRs, and keep history of file movements for easy rebase/merge on development once it gets merged.

πŸ’ 95% of deltas are import strings updated to have the internal/ part. File movements are not part of them. There are a few extra changes in logic to find the chains directory in tests in internal/lib/utils/utils.go

  • Rename *.out files to *.json to avoid gitignore conflicts
  • Do not .gitignore test_data paths
  • Move lib, dot, tests and chain to internal directory
  • Adapt import paths by adding /internal suffix to dot, lib, chain and tests import paths
  • Improve logic to find the chain directory in internal/lib/utils/utils.go
  • Rebase interactively to have a 3-commits only PR
    • Squash gitignore changes in a single commit
    • Squash file movements in a single commit
    • Squash import paths renamings in a single commit
  • MERGE (:warning:) the PR in development, not squash and merge so file movements are tracked and people can easily rebase their branches on development with git rebase development.

Tests

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #2139 (1e31ef7) into development (8fd1511) will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2139      +/-   ##
===============================================
+ Coverage        61.49%   61.52%   +0.03%     
===============================================
  Files              213      213              
  Lines            27429    27446      +17     
===============================================
+ Hits             16867    16887      +20     
+ Misses            8692     8689       -3     
  Partials          1870     1870              
Flag Coverage Ξ”
unit-tests 61.52% <81.81%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
cmd/gossamer/account.go 45.78% <ΓΈ> (ΓΈ)
cmd/gossamer/config.go 75.19% <ΓΈ> (ΓΈ)
cmd/gossamer/export.go 88.46% <ΓΈ> (ΓΈ)
cmd/gossamer/flags.go 66.66% <ΓΈ> (ΓΈ)
cmd/gossamer/import_runtime.go 40.00% <ΓΈ> (ΓΈ)
cmd/gossamer/main.go 14.28% <ΓΈ> (ΓΈ)
cmd/gossamer/toml_config.go 27.27% <ΓΈ> (ΓΈ)
cmd/gossamer/utils.go 74.35% <ΓΈ> (ΓΈ)
internal/dot/config.go 26.19% <ΓΈ> (ΓΈ)
internal/dot/core/messages.go 63.07% <ΓΈ> (ΓΈ)
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 71b2cf7...1e31ef7. Read the comment docs.

@qdm12 qdm12 force-pushed the qdm12-internal branch 4 times, most recently from c7294e6 to 091b785 Compare January 6, 2022 11:05
@qdm12
Copy link
Contributor Author

qdm12 commented Feb 11, 2022

Defunct new-year PR, some key takeaways are in #2292

@qdm12 qdm12 closed this Feb 11, 2022
@qdm12 qdm12 deleted the qdm12-internal branch February 11, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant