fix(lib/scale): Handle eof in scale decoding.

[arijitAD]

Changes

• Node crashed during adding authority nodes.
• Handle eof in scale decoding.

Tests

TestDecodeNilPublicKey
TestDecodeNilVote

Issues

• Gossamer Devnet  #592

[codecov]

Codecov Report

Merging #1675 (33e0a62) into development (028d25e) will increase coverage by 0.69%.
The diff coverage is 59.41%.

@@               Coverage Diff               @@
##           development    #1675      +/-   ##
===============================================
+ Coverage        58.50%   59.19%   +0.69%     
===============================================
  Files              160      181      +21     
  Lines            15899    18501    +2602     
===============================================
+ Hits              9301    10952    +1651     
- Misses            4924     5638     +714     
- Partials          1674     1911     +237     

Flag	Coverage Δ
unit-tests	59.19% <59.41%> (+0.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/gossamer/flags.go	57.14% <ø> (ø)
dot/network/transaction.go	46.34% <0.00%> (+2.43%)	⬆️
dot/rpc/modules/api_mocks.go	0.00% <0.00%> (ø)
dot/rpc/modules/state.go	81.66% <ø> (ø)
dot/state/bloom.go	0.00% <0.00%> (ø)
dot/state/offline_pruner.go	0.00% <0.00%> (ø)
dot/types/babe.go	48.38% <ø> (ø)
dot/types/digest.go	55.55% <0.00%> (-0.48%)	⬇️
dot/types/extrinsic.go	31.57% <0.00%> (-22.97%)	⬇️
dot/types/grandpa.go	9.52% <ø> (ø)
... and 185 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36c3b7...33e0a62. Read the comment docs.

[noot]

this seems wrong - if there's an EOF it's because there weren't enough bytes in the reader to create the public key, so there should be an error or else this will create an invalid public key

[noot]

I think this PR will likely fix any EOF issues you encountered #1662

we shouldn't be ignoring the EOFs as it will result in invalid votes/public keys

[arijitAD]

we shouldn't be ignoring the EOFs as it will result in invalid votes/public keys

Yes, I agree that we should return the error. But the node was panicking due to incorrect data from another peer. We should handle these errors gracefully in such cases.

[noot]

@arijitAD please update this to handle the error instead of ignoring, then should be good

[arijitAD]

No longer seeing this issue.