-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dot/network: improve syncing at head #1465
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1465 +/- ##
===============================================
+ Coverage 57.82% 58.01% +0.19%
===============================================
Files 152 152
Lines 15226 15307 +81
===============================================
+ Hits 8804 8881 +77
+ Misses 4878 4871 -7
- Partials 1544 1555 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, it closes an Epic, that's epic! Also, nice idea moving the logger out of the struct.
noot: fix: dot/network: improve syncing at head (#1465)
Changes
blocktree.AddBlock
to accepttypes.Header
(since it doesn't need the block body)highestBlockHeader
fromBlockState
since it's unusedBlockData
processing failure better by requesting parent block if we have a "failed to get parent hash" error (this seems to happen near the head often)Tests
Issues