[dot/rpc] implement RPC state_getKeysPaged #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmack
requested review from
anthdm,
arijitAD,
noot and
RyRy79261
as code owners
RyRy79261
approved these changes
Jan 18, 2021
noot
reviewed
Jan 18, 2021
…e/gossamer into ed/implement_state_getKeysPaged
noot
reviewed
Jan 20, 2021
dot/state/storage.go
Outdated
| hash = &sr | ||
| } | ||
|
|
||
| return s.tries[*hash].GetKeysWithPrefix(prefix), nil |
There was a problem hiding this comment.
can you error or load trie from database in the case s.tries[*hash] is nil?
There was a problem hiding this comment.
yes, good catch. All set.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
Edward Mack: [dot/rpc] implement RPC state_getKeysPaged (#1310) * implement getKeysPaged RPC and storage functions * add tests for state_getKeysPaged * use GetKeysWithPrefix for RPC call * fix GetKeysWithPrefix * add go.sum * add check if trie is nil Co-authored-by: noot <[email protected]>
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
state_getKeysPagedand tests.Tests
Checklist
Issues