Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/runtime: implement ext_local_storage_compare_and_set #1117

Merged
merged 6 commits into from
Oct 3, 2020

Conversation

edwardmack
Copy link
Member

@edwardmack edwardmack commented Oct 1, 2020

Changes

  • Implement ext function ext_local_storage_compare_and_set
  • Tests for ext_local_storage_compare_and_set

Tests

go test ./lib/runtime/...

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@edwardmack edwardmack self-assigned this Oct 1, 2020
@edwardmack edwardmack requested a review from noot October 1, 2020 23:12
@@ -29,11 +29,14 @@ import (
var memory, memErr = wasm.NewMemory(17, 0)
var logger = log.New("pkg", "runtime")

// NodeStorageType type to identify offchain storage type
type NodeStorageType int32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could by a byte?

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@edwardmack edwardmack merged commit b4848c6 into development Oct 3, 2020
@edwardmack edwardmack deleted the ed/ext_local_storage_compare_and_set branch October 3, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants