Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Research] Trie DB #2

Closed
noot opened this issue Jan 29, 2019 · 2 comments · Fixed by #116
Closed

[Research] Trie DB #2

noot opened this issue Jan 29, 2019 · 2 comments · Fixed by #116
Assignees
@priom @dutterbutter

Comments

@noot
Copy link
Contributor

noot commented Jan 29, 2019

  • see pre spec section 5
  • implement encoding of keys in tree
  • implement base-16 modified Merkle Patricia tree (ie. Trie)
  • what db are we going to use for storage?
@ansermino
Copy link
Member

Some possible DBs to use:
BoltDB - https://github.com/boltdb/bolt
BadgerDB - https://github.com/dgraph-io/badger

Hard to say which would benefit use more. BoltDB is used by Prysmatic for their Eth 2.0 client, and Badger comes recommended by @priom (iirc)

@priom
Copy link
Member

priom commented Jan 31, 2019

This looks to be pretty good; https://github.com/etcd-io/bbolt

We could start by doing some tests

@ansermino ansermino changed the title [Core] Trie DB [Research] Trie DB Feb 27, 2019
@ansermino ansermino added research and removed core labels Feb 27, 2019
@priom priom added the Backlog label Apr 9, 2019
@noot noot mentioned this issue May 13, 2019
Merged
@noot noot closed this as completed in #116 May 22, 2019
monkrus added a commit to monkrus/gossamer that referenced this issue Jul 24, 2020
@monkrus
Update CONTRIBUTING.md
a3418ca 
Update numeration, remove ChainSafe#1 and update ChainSafe#2 (former ChainSafe#3)
@edwardmack edwardmack mentioned this issue Sep 30, 2021
Merged
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priom priom

@dutterbutter dutterbutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Elizabeth/trie delete ChainSafe/gossamer
4 participants
@priom @ansermino @dutterbutter @noot