Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impelement EthGetTransactionByBlockHashAndIndex #5019

Merged
merged 7 commits into from
Dec 2, 2024
Merged

feat: impelement EthGetTransactionByBlockHashAndIndex #5019

merged 7 commits into from
Dec 2, 2024

Conversation

virajbhartiya
Copy link
Contributor

Summary of changes

Changes introduced in this pull request:

Implemented EthGetTransactionByBlockHashAndIndex RPC Method

Reference issue to close (if applicable)

Closes #4701

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@virajbhartiya virajbhartiya requested a review from a team as a code owner November 29, 2024 16:00
@virajbhartiya virajbhartiya requested review from ruseinov and elmattic and removed request for a team November 29, 2024 16:00
elmattic
elmattic reviewed Dec 2, 2024
View reviewed changes
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
ruseinov
ruseinov approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ruseinov ruseinov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, however @elmattic's nit should be addressed.

@elmattic elmattic enabled auto-merge December 2, 2024 14:39
@elmattic
Copy link
Contributor

elmattic commented Dec 2, 2024

@hanabi1224 @ruseinov Your approval is required again.

@ruseinov ruseinov self-requested a review December 2, 2024 15:10
@elmattic elmattic added this pull request to the merge queue Dec 2, 2024
Merged via the queue into ChainSafe:main with commit d2fd5de Dec 2, 2024
33 checks passed
@virajbhartiya virajbhartiya deleted the feat/EthGetTransactionByBlockHashAndIndex branch December 3, 2024 05:51
sudo-shashank pushed a commit that referenced this pull request Dec 3, 2024
@virajbhartiya @elmattic @sudo-shashank
feat: impelement EthGetTransactionByBlockHashAndIndex (#5019)
880195f 
Co-authored-by: Guillaume Potier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic left review comments

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@ruseinov ruseinov ruseinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EthGetTransactionByBlockHashAndIndex
4 participants
@virajbhartiya @elmattic @ruseinov @hanabi1224