Refactor async task spawns #2271
Conversation
|
This clashes with the changes in #2269, right? |
|
Noticed it now, can we have async task changes in this PR?, i thought that was supposed to just tweak tokio-console |
|
Sure I can remove the JoinSet change from the other PR |
creativcoder
force-pushed
the
creativcoder/tokio-console-opt
branch
from
8e33b5b to
0482c02
Compare
| validations.push(validation_fn); | ||
| let consensus = consensus.clone(); | ||
| let state_manager = state_manager.clone(); | ||
| let validation_fn = tokio::task::spawn_blocking(|| { |
There was a problem hiding this comment.
Any reason to move on a spawn_blocking here? validate_block is an async function, no?
There was a problem hiding this comment.
tokio-console shows warning when using spawn with a "⚠ n tasks have lost their waker" at this line. Replacing spawn with spawn_blocking makes the warns go away.
Update: I no longer receive those warns even with spawn after repeated runs with tokio-console, so I'm thinking of reverting this change.
There was a problem hiding this comment.
Not sure about the real root cause of this "have lost their wake" warning. Some other people are complaining of it too, see tokio-rs/console#149.
creativcoder
force-pushed
the
creativcoder/tokio-console-opt
branch
2 times, most recently
from
fdd4ea4 to
798f945
Compare
creativcoder
requested review from
lemmih,
LesnyRumcajs,
jdjaustin,
tyshko5,
hanabi1224 and
sudo-shashank
as code owners
creativcoder
force-pushed
the
creativcoder/tokio-console-opt
branch
from
c51b7cd to
c63b9c3
Compare
| @@ -1163,16 +1163,16 @@ async fn validate_tipset<DB: Blockstore + Store + Clone + Send + Sync + 'static, | |||
| debug!("Tipset keys: {:?}", full_tipset_key.cids); | |||
|
|
|||
| for b in blocks { | |||
| let validation_fn = tokio::task::spawn(validate_block::<_, C>( | |||
| let validation_fn = tokio::task::spawn(validate_block( | |||
There was a problem hiding this comment.
Is there a reason you're spawning things twice?
| let validation_fn = tokio::task::spawn(validate_block( | |
| let validation_fn = validate_block( |
|
|
||
| // Base fee check | ||
| let smoke_height = state_manager.chain_config().epoch(Height::Smoke); | ||
| let v_base_tipset = Arc::clone(&base_tipset); | ||
| let v_block_store = state_manager.blockstore().clone(); | ||
| let v_block = Arc::clone(&block); | ||
| validations.push(tokio::task::spawn_blocking(move || { | ||
| let base_fee_check = tokio::task::spawn_blocking(move || { |
There was a problem hiding this comment.
I'm not too fond of this pattern with the double spawns. A small helper function for waiting on blocking spawns might be prettier. Or we could create our own structure for having collections of validators. That way, collect_errs wouldn't be a free-standing function.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links