chore: add noble to benchmark #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
reviewed
Aug 1, 2023
test/perf/chacha20poly1305.test.ts
Outdated
| beforeEach: () => new Uint8Array(sealed), | ||
| fn: (clonedSealed) => { | ||
| jsImpl.open(nonce, clonedSealed, ad, clonedSealed.subarray(0, clonedSealed.length - TAG_LENGTH)); | ||
| chacha20poly1305Noble(key, nonce, ad).decrypt(clonedSealed); |
There was a problem hiding this comment.
Suggested change
| chacha20poly1305Noble(key, nonce, ad).decrypt(clonedSealed); | |
| chacha20poly1305Noble(key, nonce, ad).decrypt(clonedSealed, clonedSealed.subarray(0, clonedSealed.length - TAG_LENGTH)); |
to reuse buffer?
There was a problem hiding this comment.
I switched to always populate a new result every time so that I can use runsFactor to benchmark more precisely. All implementations have to populate dst result so should be no issue comparing them.
dapplion
reviewed
Aug 3, 2023
| // seal | ||
| for (const {impl, sealFn} of testCases) { | ||
| itBench({ | ||
| id: `${impl} seal ${formatBytes(dataLength)}`, |
There was a problem hiding this comment.
Format in reverse to it's easier to read,
Suggested change
| id: `${impl} seal ${formatBytes(dataLength)}`, | |
| id: `${formatBytes(dataLength)} seal ${impl}`, |
86 tasks
wemeetagain
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add noble to benchmark tests