-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extends tezos/caip10 & caip122 #40
Conversation
requires: ["CAIP-122", "CAIP-2", "CAIP-10"] | ||
--- | ||
|
||
## CAIP-122 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for Ed25519, this caip-122 for this namespace looks good, since same message format and pretty standard Ed25519 stuff, but do you want to define it for Secp256k1 and P256 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we can also define the Secp256k1 and P256, so did:tz1, did:tz2, or did:tz3 can be used. Then generated signature and its public_key should be grouped together, to ensure verification without any external APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed new changes to the Tezos namespace. Please check it for us
Co-authored-by: Zach Ferland <[email protected]>
Hey there @QibingLee -- Apologies for the delay in review. For the most part this looks good, but I had a few questions:
|
Any updates, @QibingLee ? @zachferland would you feel qualified to address my requests instead, if Qibing isn't available to get this over the line? |
- [CAIP-2](https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-2.md): Blockchain ID Specification | ||
- [CAIP-10](https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-10.md): Account ID Specification | ||
|
||
[CAIP-10]: https://github.com/ChainAgnostic/CAIPs/blob/8fdb5bfd1bdf15c9daf8aacfbcc423533764dfe9/CAIPs/caip-10.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CAIP-10]: https://github.com/ChainAgnostic/CAIPs/blob/8fdb5bfd1bdf15c9daf8aacfbcc423533764dfe9/CAIPs/caip-10.md | |
[CAIP-10]: https://ChainAgnostic.org/CAIPs/caip-10 |
Keep this open as I will likely have a look at it soon-ish |
Hey all, re: CAIP-122, could you please provide an example of how a message should look like when presented to a user for signing? It would be interesting to see if there is any meaningful difference between tz1, tz2, tz3 signers. |
@QibingLee @jdsika any update here? I actually had a follow-up question that came up in another conversation about profiling CAIP-122:
I see here in the current draft that different binary objects get prefixed by type, but what I don't understand is the (I'm going from https://tezostaquito.io/docs/signing/, please point me to a better reference if there is more current or comprehensive guidance about different signing interfaces that people are actually using in the wild! ) |
Note: the requirement to define an ENUM of valid |
@jdsika feel free to re-open if you are still working on Sign In With Tezos! |
Signed-off-by: jdsika <[email protected]>
Adds CAIPs for Tezos.