Use fallback textures for base color when no diffuse is given #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javagl
added a commit
to CesiumGS/cesium
that referenced
this pull request
Feb 12, 2024
pupitetris
pushed a commit
to pupitetris/cesium-webxr
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses CesiumGS/cesium#11821
May replace #654
When a
KHR_materials_commonhad theCONSTANTtechnique, then the resulting PBR material did not contain a base color texture, because theCONSTANTtechnique did not support diffuse textures. However, it could contain ambient or emissive textures. With the change here, the conversion will try to assign the ambient- or emissive texture as the base color texture when theCONSTANTtechnique is used.