Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default translation, rotation, scale to node targeted for animation #356

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Add default translation, rotation, scale to node targeted for animation #356

merged 2 commits into from
Mar 20, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Mar 19, 2018 •
edited
Loading

Cesium PR: CesiumGS/cesium#6351

Also fixed in the 2.0 branch: 2050870

@lilleyse lilleyse mentioned this pull request Mar 19, 2018
Merged
@coveralls
Copy link

coveralls commented Mar 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 86.295% when pulling f2dce28 on node-trs-default into 23f0082 on 2.0-cesium.

emackey
emackey approved these changes Mar 20, 2018
View reviewed changes
Copy link

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I like the new test. Left one comment about a variable name in the other review.

@lilleyse
Copy link
Contributor Author

lilleyse commented Mar 20, 2018 •
edited
Loading

@emackey Updated.

And in 2.0: e122410

@emackey
Copy link

emackey commented Mar 20, 2018

Looks great. Please merge, thanks!

@lilleyse lilleyse merged commit 6177109 into 2.0-cesium Mar 20, 2018
@lilleyse lilleyse deleted the node-trs-default branch March 20, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilleyse @coveralls @emackey