-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds styling for ModelExperimental
and ModelExperimental3DTileContent
#9896
Conversation
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag the sandcastle works fine. I had some questions and comments about the code
@ptrgags Addressed your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag just one note to prevent exposing private API while this is still experimental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag looks good to me.
@lilleyse do you want to do a review pass before we merge?
@sanjeetsuhag do you have a sandcastle that tests styling on an individual model? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better from the architecture side. The main thing that's missing here, at least from the reviewer side, is sandcastles that more honestly test the behavior of code. What I would have liked to see is a sandcastle that tests styles that are fully opaque, fully translucent, and an opaque/translucent mix with the ability to select them from a dropdown. Also an option for "No style" to see what happens if a style is unset and then later set again. And a dropdown to change the color blend mode. Then I would like to see it working for 3D Tiles with features, individual models with features, 3D Tiles without features, and individual models without features, and some mix of feature id textures and feature id attributes. Without getting too deep into the code myself a sandcastle like that would really help validate that the code is working.
Source/Scene/ModelExperimental/ModelExperimental3DTileContent.js
Outdated
Show resolved
Hide resolved
@lilleyse There's two problems happening here:
The fix was to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag sandcastles are working nicely!
Had a couple last questions for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag nearly there, just a couple last things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, @lilleyse did you want to take a last look or should I merge?
@ptrgags if you're happy you can merge |
Merged! Thanks @sanjeetsuhag |
Supersedes #9826
3D Tiles - CDB Yemen Sandcastle
3D Tiles - B3DM Sandcastle
3D Tiles - glTF Sandcastle
glTF Sandcastle using
featureIdAttributeIndex = 1
glTF Sandcastle using
featureIdAttributeIndex = 0
glTF Sandcastle using feature ID textures
Models without features
3D Tiles without features